From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
chien.yen@oracle.com, rds-devel@oss.oracle.com,
ajaykumar.hotchandani@oracle.com
Subject: Re: [PATCH 1/2] net/rds: RDS-TCP: Always create a new rds_sock for an incoming connection.
Date: Mon, 4 May 2015 15:29:08 -0400 [thread overview]
Message-ID: <20150504192908.GC26844@oracle.com> (raw)
In-Reply-To: <20150504.144720.2228274897975931117.davem@davemloft.net>
On (05/04/15 14:47), David Miller wrote:
>
> I think adding 64K of data to this module just to solve this rare
> issue is excessive.
I'd based that number mostly as a heuristic based on rds_conn_hash[].
Any suggestions for what's reasonable? 8K? Less?
(BTW, I think that should be 32K, or am I mis-counting?)
> Furthermore I don't see any locking protecting the hash table nor
> the RDS socket linkage into that table.
yes, I missed that, I'll fix that in v2.
--Sowmini
next prev parent reply other threads:[~2015-05-04 19:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 11:55 [PATCH 0/2] net/rds: RDS-TCP robustness fixes Sowmini Varadhan
2015-05-02 11:55 ` [PATCH 1/2] net/rds: RDS-TCP: Always create a new rds_sock for an incoming connection Sowmini Varadhan
2015-05-04 18:47 ` David Miller
2015-05-04 19:29 ` Sowmini Varadhan [this message]
2015-05-04 20:21 ` David Miller
2015-05-05 4:00 ` Sowmini Varadhan
2015-05-02 11:55 ` [PATCH 2/2] net/rds: RDS-TCP: only initiate reconnect attempt on outgoing TCP socket Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504192908.GC26844@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=ajaykumar.hotchandani@oracle.com \
--cc=chien.yen@oracle.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).