* [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line @ 2015-05-03 10:42 Okash Khawaja 2015-05-04 12:42 ` Kalle Valo 0 siblings, 1 reply; 4+ messages in thread From: Okash Khawaja @ 2015-05-03 10:42 UTC (permalink / raw) To: kvalo-sgV2jX0FEOL9JmXXK+q4OQ Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA This patch fixes the checkpatch.pl error: ERROR: trailing statements should be on next line More specifically, the fix has been applied to the four occurances of the error listed below. ERROR: trailing statements should be on next line #1101: FILE: drivers/net/wireless/adm8211.c:1101: + case 0x8: reg |= (0x1 << 14); ERROR: trailing statements should be on next line #1103: FILE: drivers/net/wireless/adm8211.c:1103: + case 0x16: reg |= (0x2 << 14); ERROR: trailing statements should be on next line #1105: FILE: drivers/net/wireless/adm8211.c:1105: + case 0x32: reg |= (0x3 << 14); ERROR: trailing statements should be on next line #1107: FILE: drivers/net/wireless/adm8211.c:1107: + default: reg |= (0x0 << 14); Signed-off-by: Okash Khawaja <okash.khawaja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f07a618..79e4e5f 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline); switch (cline) { - case 0x8: reg |= (0x1 << 14); - break; - case 0x16: reg |= (0x2 << 14); - break; - case 0x32: reg |= (0x3 << 14); - break; - default: reg |= (0x0 << 14); - break; + case 0x8: + reg |= (0x1 << 14); + break; + case 0x16: + reg |= (0x2 << 14); + break; + case 0x32: + reg |= (0x3 << 14); + break; + default: + reg |= (0x0 << 14); + break; } } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line 2015-05-03 10:42 [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line Okash Khawaja @ 2015-05-04 12:42 ` Kalle Valo [not found] ` <87lhh4wm3n.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Kalle Valo @ 2015-05-04 12:42 UTC (permalink / raw) To: Okash Khawaja; +Cc: linux-wireless, netdev, linux-kernel Okash Khawaja <okash.khawaja@gmail.com> writes: > This patch fixes the checkpatch.pl error: > > ERROR: trailing statements should be on next line > > More specifically, the fix has been applied to the four occurances of the error listed below. > > ERROR: trailing statements should be on next line > #1101: FILE: drivers/net/wireless/adm8211.c:1101: > + case 0x8: reg |= (0x1 << 14); > > ERROR: trailing statements should be on next line > #1103: FILE: drivers/net/wireless/adm8211.c:1103: > + case 0x16: reg |= (0x2 << 14); > > ERROR: trailing statements should be on next line > #1105: FILE: drivers/net/wireless/adm8211.c:1105: > + case 0x32: reg |= (0x3 << 14); > > ERROR: trailing statements should be on next line > #1107: FILE: drivers/net/wireless/adm8211.c:1107: > + default: reg |= (0x0 << 14); > > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> > --- > drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) The patch has incorrectly "staging:" prefix in the title, please fix that. "adm8211:" is enough, you don't need anything for drivers in drivers/net/wireless. -- Kalle Valo ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <87lhh4wm3n.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>]
* Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line [not found] ` <87lhh4wm3n.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org> @ 2015-05-05 5:19 ` Okash Khawaja 2015-05-05 5:30 ` Kalle Valo 0 siblings, 1 reply; 4+ messages in thread From: Okash Khawaja @ 2015-05-05 5:19 UTC (permalink / raw) To: Kalle Valo Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote: > Okash Khawaja <okash.khawaja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes: > > > This patch fixes the checkpatch.pl error: > > > > ERROR: trailing statements should be on next line > > > > More specifically, the fix has been applied to the four occurances of the error listed below. > > > > ERROR: trailing statements should be on next line > > #1101: FILE: drivers/net/wireless/adm8211.c:1101: > > + case 0x8: reg |= (0x1 << 14); > > > > ERROR: trailing statements should be on next line > > #1103: FILE: drivers/net/wireless/adm8211.c:1103: > > + case 0x16: reg |= (0x2 << 14); > > > > ERROR: trailing statements should be on next line > > #1105: FILE: drivers/net/wireless/adm8211.c:1105: > > + case 0x32: reg |= (0x3 << 14); > > > > ERROR: trailing statements should be on next line > > #1107: FILE: drivers/net/wireless/adm8211.c:1107: > > + default: reg |= (0x0 << 14); > > > > Signed-off-by: Okash Khawaja <okash.khawaja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > --- > > drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- > > 1 file changed, 12 insertions(+), 8 deletions(-) > > The patch has incorrectly "staging:" prefix in the title, please fix > that. "adm8211:" is enough, you don't need anything for drivers in > drivers/net/wireless. > > -- > Kalle Valo Thanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below. Signed-off-by: Okash Khawaja <okash.khawaja-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f07a618..79e4e5f 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev) pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline); switch (cline) { - case 0x8: reg |= (0x1 << 14); - break; - case 0x16: reg |= (0x2 << 14); - break; - case 0x32: reg |= (0x3 << 14); - break; - default: reg |= (0x0 << 14); - break; + case 0x8: + reg |= (0x1 << 14); + break; + case 0x16: + reg |= (0x2 << 14); + break; + case 0x32: + reg |= (0x3 << 14); + break; + default: + reg |= (0x0 << 14); + break; } } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] adm8211: fix checkpatch error for trailing statements on next line 2015-05-05 5:19 ` [PATCH v2] " Okash Khawaja @ 2015-05-05 5:30 ` Kalle Valo 0 siblings, 0 replies; 4+ messages in thread From: Kalle Valo @ 2015-05-05 5:30 UTC (permalink / raw) To: Okash Khawaja; +Cc: linux-wireless, netdev, linux-kernel Okash Khawaja <okash.khawaja@gmail.com> writes: > On Mon, May 04, 2015 at 03:42:04PM +0300, Kalle Valo wrote: >> Okash Khawaja <okash.khawaja@gmail.com> writes: >> >> > This patch fixes the checkpatch.pl error: >> > >> > ERROR: trailing statements should be on next line >> > >> > More specifically, the fix has been applied to the four occurances of the error listed below. >> > >> > ERROR: trailing statements should be on next line >> > #1101: FILE: drivers/net/wireless/adm8211.c:1101: >> > + case 0x8: reg |= (0x1 << 14); >> > >> > ERROR: trailing statements should be on next line >> > #1103: FILE: drivers/net/wireless/adm8211.c:1103: >> > + case 0x16: reg |= (0x2 << 14); >> > >> > ERROR: trailing statements should be on next line >> > #1105: FILE: drivers/net/wireless/adm8211.c:1105: >> > + case 0x32: reg |= (0x3 << 14); >> > >> > ERROR: trailing statements should be on next line >> > #1107: FILE: drivers/net/wireless/adm8211.c:1107: >> > + default: reg |= (0x0 << 14); >> > >> > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> >> > --- >> > drivers/net/wireless/adm8211.c | 20 ++++++++++++-------- >> > 1 file changed, 12 insertions(+), 8 deletions(-) >> >> The patch has incorrectly "staging:" prefix in the title, please fix >> that. "adm8211:" is enough, you don't need anything for drivers in >> drivers/net/wireless. >> >> -- >> Kalle Valo > > Thanks Kalle for clarifying. I have removed "staging:" prefix and pasted the patch below. > > Signed-off-by: Okash Khawaja <okash.khawaja@gmail.com> I cannot apply the mail directly as you added the old discussion to the commit log. Please just resend the whole patch with clean commit log. -- Kalle Valo ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-05 5:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-03 10:42 [PATCH] staging: adm8211: fix checkpatch error for trailing statements on next line Okash Khawaja
2015-05-04 12:42 ` Kalle Valo
[not found] ` <87lhh4wm3n.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-05-05 5:19 ` [PATCH v2] " Okash Khawaja
2015-05-05 5:30 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).