From: Okash Khawaja <okash.khawaja@gmail.com>
To: joe@perches.com, kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] adm8211: fix checkpatch error for trailing statements on next line
Date: Tue, 5 May 2015 12:45:17 +0100 [thread overview]
Message-ID: <20150505114517.GA2934@bytefire-computer> (raw)
In-Reply-To: <1430808298.7191.1.camel@perches.com>
On Mon, May 04, 2015 at 11:44:58PM -0700, Joe Perches wrote:
> On Tue, 2015-05-05 at 07:01 +0100, Okash Khawaja wrote:
> > This patch fixes the checkpatch.pl error:
>
> Please fix the space/tab use too.
>
> Your email client seems to have converted all the tabs
> to spaces.
>
> default should use the same indent as the case statements
>
Joe and Kalle,
I have adjusted the patch. Since indentation of default adds more to the
patch I have resent it under the subject '[PATCH] adm8211: fix
checkpatch errors for indentation and new line around switch-case'.
Thanks for the prompt feedback. I appreciate your patience.
>
> > diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
> []
> > @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)
> > pci_read_config_byte(priv->pdev, PCI_CACHE_LINE_SIZE, &cline);
> >
> > switch (cline) {
> > - case 0x8: reg |= (0x1 << 14);
> > - break;
> > - case 0x16: reg |= (0x2 << 14);
> > - break;
> > - case 0x32: reg |= (0x3 << 14);
> > - break;
> > - default: reg |= (0x0 << 14);
> > - break;
> > + case 0x8:
> > + reg |= (0x1 << 14);
> > + break;
> > + case 0x16:
> > + reg |= (0x2 << 14);
> > + break;
> > + case 0x32:
> > + reg |= (0x3 << 14);
> > + break;
> > + default:
> > + reg |= (0x0 << 14);
> > + break;
> > }
> > }
> >
>
prev parent reply other threads:[~2015-05-05 11:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 6:01 [PATCH v3] adm8211: fix checkpatch error for trailing statements on next line Okash Khawaja
2015-05-05 6:44 ` Joe Perches
2015-05-05 11:45 ` Okash Khawaja [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505114517.GA2934@bytefire-computer \
--to=okash.khawaja@gmail.com \
--cc=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).