Re: [PATCH 01/10] net: Use cached copy of pfmemalloc to avoid accessing page

David Miller
2015-05-10T23:18:51Z

From: Alexander Duyck <alexander.h.duyck@redhat.com>
Date: Wed, 06 May 2015 21:11:40 -0700

> + /* use OR instead of assignment to avoid clearing of bits in mask */
> + if (pfmemalloc)
> + skb->pfmemalloc = 1;
> + skb->head_frag = 1;
...
> + /* use OR instead of assignment to avoid clearing of bits in mask */
> + if (nc->pfmemalloc)
> + skb->pfmemalloc = 1;
> + skb->head_frag = 1;

Maybe make these two cases more consistent by either accessing
nc->pfmemalloc or using a local variable in both cases.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: email@kvack.org