From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id Date: Fri, 8 May 2015 18:49:17 +0200 Message-ID: <20150508164917.GL18496@lunn.ch> References: <1431094729-21775-1-git-send-email-bert@biot.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Bert Vermeulen Return-path: Content-Disposition: inline In-Reply-To: <1431094729-21775-1-git-send-email-bert@biot.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, May 08, 2015 at 04:18:49PM +0200, Bert Vermeulen wrote: > When the bus id was supplied via a struct platform_device, the driver wasn't > handling -1 to mean an unspecified id of the only instance of this driver, > as the platform spec requires. > > Signed-off-by: Bert Vermeulen > --- > drivers/net/phy/mdio-gpio.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c > index f5cddf5..7bd90db 100644 > --- a/drivers/net/phy/mdio-gpio.c > +++ b/drivers/net/phy/mdio-gpio.c > @@ -165,7 +165,10 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev, > if (!new_bus->irq[i]) > new_bus->irq[i] = PHY_POLL; > > - snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > + if (bus_id != -1) > + snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > + else > + strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE); > > if (devm_gpio_request(dev, bitbang->mdc, "mdc")) > goto out_free_bus; > -- Reviewed-by: Andrew Lunn Andrew