From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH -next] net: sched: use counter to break reclassify loops
Date: Mon, 11 May 2015 13:30:07 -0700 [thread overview]
Message-ID: <20150511203006.GA2914@Alexeis-MacBook-Pro.local> (raw)
In-Reply-To: <1431366641-24735-1-git-send-email-fw@strlen.de>
On Mon, May 11, 2015 at 07:50:41PM +0200, Florian Westphal wrote:
> Seems all we want here is to avoid endless 'goto reclassify' loop.
> tc_classify_compat even resets this counter when something other
> than TC_ACT_RECLASSIFY is returned, so this skb-counter doesn't
> break hypothetical loops induced by something other than perpetual
> TC_ACT_RECLASSIFY return values.
>
> skb_act_clone is now identical to skb_clone, so just use that.
>
> Tested with following (bogus) filter:
> tc filter add dev eth0 parent ffff: \
> protocol ip u32 match u32 0 0 police rate 10Kbit burst \
> 64000 mtu 1500 action reclassify
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Florian Westphal <fw@strlen.de>
agree. that's my reading of the code as well.
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-05-11 20:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 17:50 [PATCH -next] net: sched: use counter to break reclassify loops Florian Westphal
2015-05-11 20:30 ` Alexei Starovoitov [this message]
2015-05-12 11:38 ` Jamal Hadi Salim
2015-05-12 13:00 ` Florian Westphal
2015-05-13 11:18 ` Jamal Hadi Salim
2015-05-13 11:29 ` Florian Westphal
2015-05-13 12:04 ` Jamal Hadi Salim
2015-05-13 12:44 ` Florian Westphal
2015-05-13 19:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511203006.GA2914@Alexeis-MacBook-Pro.local \
--to=alexei.starovoitov@gmail.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).