netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: sched: use counter to break reclassify loops
Date: Tue, 12 May 2015 15:00:29 +0200	[thread overview]
Message-ID: <20150512130029.GA22387@breakpoint.cc> (raw)
In-Reply-To: <5551E62D.5040507@mojatatu.com>

Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> Florian,
> In general i am in support of removing this - since the use case never
> materialized as being useful. However, this is not the same logic that
> was there before. To get equivalency you need to pass the limit into
> tc_classify_compat() so i can be reset.

AFAICS this re-set only happens when we return something other
than RECLASSIFY which means the caller will not check the limit.

So in fact it should be ok to remove this since the counter will always
start from 0 on next tc_classify() invocation.

> BTW, a faster way to recreate
> tc filter add dev eth0 parent ffff: \
>   protocol ip u32 match u32 0 0 \
> action reclassify

Indeed, thanks for the hint.

  reply	other threads:[~2015-05-12 13:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 17:50 [PATCH -next] net: sched: use counter to break reclassify loops Florian Westphal
2015-05-11 20:30 ` Alexei Starovoitov
2015-05-12 11:38 ` Jamal Hadi Salim
2015-05-12 13:00   ` Florian Westphal [this message]
2015-05-13 11:18     ` Jamal Hadi Salim
2015-05-13 11:29       ` Florian Westphal
2015-05-13 12:04         ` Jamal Hadi Salim
2015-05-13 12:44           ` Florian Westphal
2015-05-13 19:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512130029.GA22387@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).