From: Jiri Pirko <jiri@resnulli.us>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
j.vosburgh@gmail.com, vfalico@gmail.com,
gospo@cumulusnetworks.com
Subject: Re: [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface
Date: Tue, 12 May 2015 18:14:02 +0200 [thread overview]
Message-ID: <20150512161402.GC2081@nanopsycho> (raw)
In-Reply-To: <55522610.6090907@6wind.com>
Tue, May 12, 2015 at 06:10:56PM CEST, nicolas.dichtel@6wind.com wrote:
>Le 12/05/2015 17:58, Jiri Pirko a écrit :
>>Tue, May 12, 2015 at 05:17:45PM CEST, nicolas.dichtel@6wind.com wrote:
>[snip]
>>>First, nobody seems to care about NETDEV_CHANGEINFODATA (commit
>>>d4261e565000 says that it was put only to notify userspace). Hence, we can
>>>call directly rtmsg_ifinfo().
>>
>>Please leave this notifier here. Will be needed in very near future for
>>LAG offloading purposes.
>Ok.
>
>>
>>>Secondly, prevent in rtmsg_ifinfo() to send notifications to userspace
>>>about unregistered interfaces.
>>
>>I'm not sure about this. Why caller of rtmsg_ifinfo don't take care of
>>it? Seems more logical to me.
>Simply to avoid code duplication and ensure the bug will not show up in the
>future. The existing bug shows that it's easy to forget that check.
I don't know, seems to me more like curing consequence, not the cause.
next prev parent reply other threads:[~2015-05-12 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:25 [PATCH net] rtnl: don't send rtnl msg for unregistered iface Nicolas Dichtel
2015-05-11 15:37 ` Jiri Pirko
2015-05-11 16:04 ` Nicolas Dichtel
2015-05-11 16:15 ` Nicolas Dichtel
2015-05-11 17:53 ` Jiri Pirko
2015-05-11 22:15 ` Andy Gospodarek
2015-05-12 8:43 ` Nicolas Dichtel
2015-05-12 15:03 ` [PATCH net v2] rtnl/bond: " Nicolas Dichtel
2015-05-12 15:06 ` Nicolas Dichtel
2015-05-12 15:17 ` [PATCH net v3] " Nicolas Dichtel
2015-05-12 15:58 ` Jiri Pirko
2015-05-12 16:10 ` Nicolas Dichtel
2015-05-12 16:14 ` Jiri Pirko [this message]
2015-05-13 12:19 ` [PATCH net v4] " Nicolas Dichtel
2015-05-13 12:24 ` Jiri Pirko
2015-05-13 12:36 ` Nicolas Dichtel
2015-05-18 2:44 ` David Miller
2015-07-13 14:11 ` Kristian Evensen
2015-07-15 15:07 ` Nicolas Dichtel
2015-07-16 9:06 ` Nicolas Dichtel
2015-07-16 9:31 ` [PATCH linux-3.18.y] rtnl: restore notifications for deleted interfaces Nicolas Dichtel
2015-05-12 17:12 ` [PATCH net v3] rtnl/bond: don't send rtnl msg for unregistered iface Andy Gospodarek
2015-05-13 12:01 ` Nicolas Dichtel
2015-05-13 14:43 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150512161402.GC2081@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=gospo@cumulusnetworks.com \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox