From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH v2 net-next 0/2] tcp: tcp_info extensions Date: Tue, 12 May 2015 19:21:50 -0300 Message-ID: <20150512222150.GE13809@localhost.localdomain> References: <1430260098-14127-1-git-send-email-edumazet@google.com> <20150512130855.GA29412@localhost.localdomain> <1431462713.566.95.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , netdev , Yuchung Cheng , Matt Mathis , Craig Gallek , Martin Lau , Chris Rapier To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56055 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028AbbELWWG (ORCPT ); Tue, 12 May 2015 18:22:06 -0400 Content-Disposition: inline In-Reply-To: <1431462713.566.95.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, May 12, 2015 at 01:31:53PM -0700, Eric Dumazet wrote: > On Tue, 2015-05-12 at 10:08 -0300, Marcelo Ricardo Leitner wrote: > > On Tue, Apr 28, 2015 at 03:28:16PM -0700, Eric Dumazet wrote: > > > As discussed during Chris Rapier presentation in Ottawa / netdev0.1, > > > we add to tcp_info the first two fields are highly wanted. > > > > > > Each field is added into a single patch for easy code review. > > > > > > (Corresponding iproute2/ss patches will be sent) > > > > > > Next fields will follow once consensus is reached. > > > > Is tcpEStatsPerfSegsOut amongst them? I have a need for this one and can > > submit a patch if you're not tracking it already. > > Yes, along with tcpEStatsPerfSegsIn > > Because tcp_info is aligned to 64bits, we cannot cook a patch simply > adding tcpEStatsPerfSegsOut (u32), otherwise we would introduce a hole. Oh ok, thanks for pointing this out. > If you can cook the patch adding tcpEStatsPerfSegsOut and > tcpEStatsPerfSegsIn, I would be very happy to review it. Cool, will do it, thanks! Marcelo