From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD Date: Wed, 13 May 2015 07:42:50 +0200 Message-ID: <20150513054250.GA2126@nanopsycho> References: <1431494830-4284-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, sfeldma@gmail.com, gospo@cumulusnetworks.com, netdev@vger.kernel.org To: roopa@cumulusnetworks.com Return-path: Received: from mail-wi0-f181.google.com ([209.85.212.181]:35593 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbbEMFnD (ORCPT ); Wed, 13 May 2015 01:43:03 -0400 Received: by widdi4 with SMTP id di4so182723530wid.0 for ; Tue, 12 May 2015 22:43:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1431494830-4284-1-git-send-email-roopa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: Wed, May 13, 2015 at 07:27:10AM CEST, roopa@cumulusnetworks.com wrote: >From: Roopa Prabhu > >RTNH_F_EXTERNAL today is printed as "offload" in iproute2 output. > >This patch renames the flag to be consistent with what the user sees. > >(I will post iproute2 patch if this gets accepted) > >Signed-off-by: Roopa Prabhu >--- > include/uapi/linux/rtnetlink.h | 2 +- > net/ipv4/fib_trie.c | 2 +- > net/switchdev/switchdev.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > >diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >index 974db03..17fb02f 100644 >--- a/include/uapi/linux/rtnetlink.h >+++ b/include/uapi/linux/rtnetlink.h >@@ -337,7 +337,7 @@ struct rtnexthop { > #define RTNH_F_DEAD 1 /* Nexthop is dead (used by multipath) */ > #define RTNH_F_PERVASIVE 2 /* Do recursive gateway lookup */ > #define RTNH_F_ONLINK 4 /* Gateway is forced on link */ >-#define RTNH_F_EXTERNAL 8 /* Route installed externally */ >+#define RTNH_F_OFFLOAD 8 /* offloaded route */ Since this is part of uapi, I believe this is not doable :/