Re: [PATCH -next] net: sched: use counter to break reclassify loops

[Florian Westphal <fw@strlen.de>]

Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 05/13/15 07:29, Florian Westphal wrote:
> >Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >Yes, but, if we use your example above then:
> >
> >tc_classify called
> >   limit 0
> >     tc_classify_compat called, ret RECLASSIFY
> >   limit 1
> >     tc_classify_compat called, ret RECLASSIFY
> >   limit 2
> >     tc_classify_compat called, ret PIPE (== 3)
> >   tc_classify returns 3
> >tc_classify called
> >   limit 0
> >   ...
> >
> >So we don't toss skb since any return value other than RECLASSIFY
> >will make tc_classify() return to its caller, and when caller invokes
> >tc_classify again the limit variable is set to 0 again.
> >
> >Does that make sense to you?
> >
> 
> I think you are right.

[..]

> In any case, lets not slow this down; please add my acked-by and if
> i can think of something i will post. I have to take off, so i will go
> quiet for a while.

Ok.  Again, many thanks Jamal for all the help you've provided.

In case you were not aware: thanks to patchwork its enough to reply with

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>

... and it will be appended to the patch automagically.