From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH -next v3] net: core: set qdisc pkt len before tc_classify
Date: Wed, 13 May 2015 16:54:37 -0700 [thread overview]
Message-ID: <20150513235436.GA4851@Alexeis-MacBook-Pro.local> (raw)
In-Reply-To: <1431556588-4859-1-git-send-email-fw@strlen.de>
On Thu, May 14, 2015 at 12:36:28AM +0200, Florian Westphal wrote:
> commit d2788d34885d4ce5ba ("net: sched: further simplify handle_ing")
> removed the call to qdisc_enqueue_root().
>
> However, after this removal we no longer set qdisc pkt length.
> This breaks traffic policing on ingress.
>
> This is the minimum fix: set qdisc pkt length before tc_classify.
Thanks!
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-05-13 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 22:36 [PATCH -next v3] net: core: set qdisc pkt len before tc_classify Florian Westphal
2015-05-13 22:49 ` Eric Dumazet
2015-05-13 23:54 ` Alexei Starovoitov [this message]
2015-05-14 0:10 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150513235436.GA4851@Alexeis-MacBook-Pro.local \
--to=alexei.starovoitov@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox