From: David Miller <davem@davemloft.net>
To: brian.haley@hp.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us
Subject: Re: [PATCH v2] cls_flower: Fix compile error
Date: Thu, 14 May 2015 13:02:30 -0400 (EDT) [thread overview]
Message-ID: <20150514.130230.1692424946326313157.davem@davemloft.net> (raw)
In-Reply-To: <5554D249.6080204@hp.com>
From: Brian Haley <brian.haley@hp.com>
Date: Thu, 14 May 2015 12:50:17 -0400
> Fix compile error in net/sched/cls_flower.c
>
> net/sched/cls_flower.c: In function ‘fl_set_key’:
> net/sched/cls_flower.c:240:3: error: implicit declaration of function
> ‘tcf_change_indev’ [-Werror=implicit-function-declaration]
> err = tcf_change_indev(net, tb[TCA_FLOWER_INDEV]);
>
> Introduced in 77b9900ef53ae047e36a37d13a2aa33bb2d60641
>
> Signed-off-by: Brian Haley <brian.haley@hp.com>
>
> diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
> index 9bc654c..8c8f34e 100644
> --- a/net/sched/cls_flower.c
> +++ b/net/sched/cls_flower.c
> @@ -234,15 +234,15 @@ static void fl_set_key_val(struct nlattr **tb,
> static int fl_set_key(struct net *net, struct nlattr **tb,
> struct fl_flow_key *key, struct fl_flow_key *mask)
> {
> - int err;
> -
This patch is corrupted by your email client.
Also, referring to a guilty patch is done using the "Fixes: " tag
which should appear right before your signoff. It is to be of
the form:
Fixes: $(SHA1_ID) ("Commit summary line text")
The SHA1_ID should be of 12 characters of significance.
prev parent reply other threads:[~2015-05-14 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 16:50 [PATCH v2] cls_flower: Fix compile error Brian Haley
2015-05-14 17:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514.130230.1692424946326313157.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=brian.haley@hp.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).