From: David Miller <davem@davemloft.net>
To: alexander.h.duyck@redhat.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [net-next PATCH v3] ip_tunnel: Report Rx dropped in ip_tunnel_get_stats64
Date: Thu, 14 May 2015 22:33:13 -0400 (EDT) [thread overview]
Message-ID: <20150514.223313.2022997448767456512.davem@davemloft.net> (raw)
In-Reply-To: <20150514212855.1301.93235.stgit@ahduyck-vm-fedora22>
From: Alexander Duyck <alexander.h.duyck@redhat.com>
Date: Thu, 14 May 2015 14:31:28 -0700
> The rx_dropped stat wasn't being reported when ip_tunnel_get_stats64 was
> called. This was leading to some confusing results in my debug as I was
> seeing rx_errors increment but no other value which pointed me toward the
> type of error being seen.
>
> This change corrects that by using netdev_stats_to_stats64 to copy all
> available dev stats instead of just the few that were hand picked.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Applied, thanks Alexander.
prev parent reply other threads:[~2015-05-15 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 21:31 [net-next PATCH v3] ip_tunnel: Report Rx dropped in ip_tunnel_get_stats64 Alexander Duyck
2015-05-14 21:55 ` Eric Dumazet
2015-05-15 2:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514.223313.2022997448767456512.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).