From: Ivan Mikhaylov <ivan@ru.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/2] net/ibm/emac: fix size of emac dump memory areas
Date: Thu, 14 May 2015 16:04:34 +0400 [thread overview]
Message-ID: <20150514160434.29ea2603@fr-ThinkPad-W520> (raw)
In-Reply-To: <20150512171200.207dfd7b@fr-ThinkPad-W520>
On Tue, 12 May 2015 17:12:00 +0400
Ivan Mikhaylov <ivan@ru.ibm.com> wrote:
>>On Tue, 2015-05-12 at 17:12 +0400, Ivan Mikhaylov wrote:
>> Fix in send of emac regs dump to ethtool which
>> causing wrong data interpretation on ethtool
>> layer for MII and EMAC.
>
>Please provide a better explanation. You removed the difference
>in register space size between EMAC and EMAC4, why ? You also changed a
>test regarding which version of the structure to use from EMAC4 to
>EMAC4SYNC, why ?
So, as I understand right, we have EMAC, EMAC4, EMAC4SYNC chips right now?
But within driver structure there are only EMAC4/EMAC4SYNC that I'm seeing or
is it include and EMAC? I thought that only EMAC4/EMAC4SYNC we have.
Anyway we have bug in ethtool, there size of emac_regs is defined and if we
will provide wrong size of emac_regs structure that will cause problems in
showing of some emac_regs fields for emac4sync + MII layer. Plus size of
register space can be different on different platforms so because of this
I removed macroses which doing this right from it. So just for example
we have 0x100 for emac4sync in dts file, sizeof on ethtool is 152 always for
emac_regs and we're reading MII values from emac area where is no data for
MII.
I have to add emac4sync support to ethtool regdump as I see in plus to
EMAC/EMAC4. What your opinion on this?
prev parent reply other threads:[~2015-05-14 12:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 13:12 [PATCH 2/2] net/ibm/emac: fix size of emac dump memory areas Ivan Mikhaylov
2015-05-12 20:49 ` Benjamin Herrenschmidt
2015-05-14 12:04 ` Ivan Mikhaylov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514160434.29ea2603@fr-ThinkPad-W520 \
--to=ivan@ru.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).