* [net-next:master 353/365] drivers/net/ethernet/emulex/benet/be_main.c:5473:9: sparse: symbol 'be_hwmon_show_temp' was not declared. Should it be static?
@ 2015-05-14 19:02 kbuild test robot
2015-05-14 19:02 ` [PATCH net-next] be2net: be_hwmon_show_temp() can be static kbuild test robot
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-05-14 19:02 UTC (permalink / raw)
To: Venkata Duvvuru
Cc: kbuild-all, Venkat Duvvuru, Sathya Perla, Ajit Khaparde,
Padmanabh Ratnakar, Sriharsha Basavapatna, netdev, linux-kernel
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: b55b10bebb86a436bebd5c754f80076ad51f4068
commit: 29e9122b3ab2aa7160e54c2bbea242b99588325c [353/365] be2net: Export board temperature using hwmon-sysfs interface.
reproduce:
# apt-get install sparse
git checkout 29e9122b3ab2aa7160e54c2bbea242b99588325c
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
drivers/net/ethernet/emulex/benet/be_main.c:1266:29: sparse: incorrect type in assignment (different base types)
drivers/net/ethernet/emulex/benet/be_main.c:1266:29: expected unsigned short [unsigned] [short] <noident>
drivers/net/ethernet/emulex/benet/be_main.c:1266:29: got restricted __le16 [usertype] <noident>
drivers/net/ethernet/emulex/benet/be_main.c:2182:32: sparse: incorrect type in assignment (different base types)
drivers/net/ethernet/emulex/benet/be_main.c:2182:32: expected unsigned int [unsigned] [usertype] fragpa_lo
drivers/net/ethernet/emulex/benet/be_main.c:2182:32: got restricted __le32 [usertype] <noident>
drivers/net/ethernet/emulex/benet/be_main.c:2183:32: sparse: incorrect type in assignment (different base types)
drivers/net/ethernet/emulex/benet/be_main.c:2183:32: expected unsigned int [unsigned] [usertype] fragpa_hi
drivers/net/ethernet/emulex/benet/be_main.c:2183:32: got restricted __le32 [usertype] <noident>
drivers/net/ethernet/emulex/benet/be_main.c:4318:36: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4320:36: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4531:24: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4532:26: sparse: cast to restricted __le16
drivers/net/ethernet/emulex/benet/be_main.c:4602:25: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4603:30: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4604:30: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4605:30: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4831:20: sparse: cast to restricted __le32
drivers/net/ethernet/emulex/benet/be_main.c:4837:21: sparse: cast to restricted __le32
>> drivers/net/ethernet/emulex/benet/be_main.c:5473:9: sparse: symbol 'be_hwmon_show_temp' was not declared. Should it be static?
drivers/net/ethernet/emulex/benet/be_main.c:4785:24: sparse: odd constant _Bool cast (ffffffffffffffff becomes 1)
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] be2net: be_hwmon_show_temp() can be static
2015-05-14 19:02 [net-next:master 353/365] drivers/net/ethernet/emulex/benet/be_main.c:5473:9: sparse: symbol 'be_hwmon_show_temp' was not declared. Should it be static? kbuild test robot
@ 2015-05-14 19:02 ` kbuild test robot
2015-05-14 21:39 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2015-05-14 19:02 UTC (permalink / raw)
To: Ying Xue
Cc: kbuild-all, Sathya Perla, Ajit Khaparde, Padmanabh Ratnakar,
Sriharsha Basavapatna, netdev, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index dc7c0fd..76d491f 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
free_netdev(adapter->netdev);
}
-ssize_t be_hwmon_show_temp(struct device *dev,
+static ssize_t be_hwmon_show_temp(struct device *dev,
struct device_attribute *dev_attr,
char *buf)
{
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] be2net: be_hwmon_show_temp() can be static
2015-05-14 19:02 ` [PATCH net-next] be2net: be_hwmon_show_temp() can be static kbuild test robot
@ 2015-05-14 21:39 ` David Miller
2015-05-15 5:19 ` Fengguang Wu
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2015-05-14 21:39 UTC (permalink / raw)
To: fengguang.wu
Cc: ying.xue, kbuild-all, sathya.perla, ajit.khaparde,
padmanabh.ratnakar, sriharsha.basavapatna, netdev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Fri, 15 May 2015 03:02:35 +0800
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> be_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> index dc7c0fd..76d491f 100644
> --- a/drivers/net/ethernet/emulex/benet/be_main.c
> +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> @@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
> free_netdev(adapter->netdev);
> }
>
> -ssize_t be_hwmon_show_temp(struct device *dev,
> +static ssize_t be_hwmon_show_temp(struct device *dev,
> struct device_attribute *dev_attr,
> char *buf)
If you adjust the column of the openning parenthesis of the
function, you have to reindent the subsequent lines so that they
start precisely at the very next column.
You must use the appropriate number of TAB and SPACE characters
necessary to do so.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] be2net: be_hwmon_show_temp() can be static
2015-05-14 21:39 ` David Miller
@ 2015-05-15 5:19 ` Fengguang Wu
0 siblings, 0 replies; 4+ messages in thread
From: Fengguang Wu @ 2015-05-15 5:19 UTC (permalink / raw)
To: David Miller
Cc: ying.xue, kbuild-all, sathya.perla, ajit.khaparde,
padmanabh.ratnakar, sriharsha.basavapatna, netdev, linux-kernel
On Thu, May 14, 2015 at 05:39:46PM -0400, David Miller wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
> Date: Fri, 15 May 2015 03:02:35 +0800
>
> >
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > be_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
> > index dc7c0fd..76d491f 100644
> > --- a/drivers/net/ethernet/emulex/benet/be_main.c
> > +++ b/drivers/net/ethernet/emulex/benet/be_main.c
> > @@ -5612,7 +5612,7 @@ static void be_remove(struct pci_dev *pdev)
> > free_netdev(adapter->netdev);
> > }
> >
> > -ssize_t be_hwmon_show_temp(struct device *dev,
> > +static ssize_t be_hwmon_show_temp(struct device *dev,
> > struct device_attribute *dev_attr,
> > char *buf)
>
> If you adjust the column of the openning parenthesis of the
> function, you have to reindent the subsequent lines so that they
> start precisely at the very next column.
>
> You must use the appropriate number of TAB and SPACE characters
> necessary to do so.
OK. We'll improve the script to adjust indent accordingly.
Thanks,
Fengguang
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-15 5:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-14 19:02 [net-next:master 353/365] drivers/net/ethernet/emulex/benet/be_main.c:5473:9: sparse: symbol 'be_hwmon_show_temp' was not declared. Should it be static? kbuild test robot
2015-05-14 19:02 ` [PATCH net-next] be2net: be_hwmon_show_temp() can be static kbuild test robot
2015-05-14 21:39 ` David Miller
2015-05-15 5:19 ` Fengguang Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).