From: David Miller <davem@redhat.com>
To: herbert@gondor.apana.org.au
Cc: eric.dumazet@gmail.com, tgraf@suug.ch, netdev@vger.kernel.org,
ying.xue@windriver.com
Subject: Re: netlink: Kill bogus lock_sock in netlink_insert
Date: Fri, 15 May 2015 13:02:19 -0400 (EDT) [thread overview]
Message-ID: <20150515.130219.331336809636676892.davem@redhat.com> (raw)
In-Reply-To: <20150514060230.GD6058@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 14 May 2015 14:02:30 +0800
> The commit c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink:
> eliminate nl_sk_hash_lock") added a lock_sock to netlink_insert
> with no justifications whatsoever.
>
> This patch kills it.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Actually, Herbert, I think this lock_sock() is needed.
Otherwise nothing protects nlk_sk(sk)->portid, upon which we
perform a non-atomic test-and-set operation here.
If you remove the lock_sock(), two parallel bind/inserts are
possible on the same socket, potentially resulting in socket
state corruption.
next prev parent reply other threads:[~2015-05-15 17:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 5:30 netlink & rhashtable status Eric Dumazet
2015-05-13 5:40 ` Herbert Xu
2015-05-13 6:15 ` Eric Dumazet
2015-05-13 6:20 ` Herbert Xu
2015-05-13 13:04 ` Eric Dumazet
2015-05-13 16:18 ` Eric Dumazet
2015-05-13 16:35 ` David Miller
2015-05-14 2:55 ` Herbert Xu
2015-05-14 2:53 ` Herbert Xu
2015-05-14 3:17 ` Eric Dumazet
2015-05-14 3:34 ` Herbert Xu
2015-05-14 3:58 ` Eric Dumazet
2015-05-14 4:13 ` Eric Dumazet
2015-05-14 4:16 ` Herbert Xu
2015-05-14 4:21 ` Herbert Xu
2015-05-14 4:38 ` Eric Dumazet
2015-05-14 5:03 ` Herbert Xu
2015-05-14 5:56 ` Red Hat INTERNAL-ONLY kernel discussion list <rhkernel-list@redhat.com> Herbert Xu
2015-05-14 5:58 ` netlink: Disable insertions/removals during rehash Herbert Xu
2015-05-14 6:02 ` netlink: Kill bogus lock_sock in netlink_insert Herbert Xu
2015-05-15 16:49 ` David Miller
2015-05-15 18:01 ` Eric Dumazet
2015-05-16 16:50 ` Eric Dumazet
2015-05-16 20:58 ` David Miller
2015-05-15 17:02 ` David Miller [this message]
2015-05-16 12:32 ` Herbert Xu
2015-05-16 13:40 ` [net] netlink: Make autobind rover an atomic_t Herbert Xu
2015-05-16 13:50 ` [net] netlink: Reset portid after netlink_insert failure Herbert Xu
2015-05-16 21:09 ` David Miller
2015-05-16 21:08 ` [net] netlink: Make autobind rover an atomic_t David Miller
2015-05-17 2:45 ` [net-next] netlink: Use random autobind rover Herbert Xu
2015-05-18 3:44 ` David Miller
2015-05-14 14:37 ` netlink: Disable insertions/removals during rehash Eric Dumazet
2015-05-15 0:06 ` Herbert Xu
2015-05-20 23:53 ` Thomas Graf
2015-05-21 0:31 ` Eric Dumazet
2015-05-15 17:02 ` David Miller
2015-05-16 13:16 ` Herbert Xu
2015-05-16 21:10 ` David Miller
2015-06-04 16:27 ` Guenter Roeck
2015-06-04 18:59 ` David Miller
2015-06-04 20:44 ` Eric Dumazet
2015-06-04 20:58 ` Guenter Roeck
2015-06-05 3:52 ` Herbert Xu
2015-06-05 5:27 ` Guenter Roeck
2015-06-26 10:44 ` netlink & rhashtable status Konstantin Khlebnikov
2015-06-27 7:09 ` Herbert Xu
2015-05-14 4:17 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150515.130219.331336809636676892.davem@redhat.com \
--to=davem@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).