* [PATCH net-next] netfilter: synproxy: fix sparse errors
@ 2015-05-15 16:07 Eric Dumazet
2015-05-15 18:05 ` Pablo Neira Ayuso
2015-05-17 18:11 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2015-05-15 16:07 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Patrick McHardy, Pablo Neira Ayuso
From: Eric Dumazet <edumazet@google.com>
Fix verbose sparse errors :
make C=2 CF=-D__CHECK_ENDIAN__ net/ipv4/netfilter/ipt_SYNPROXY.o
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
Trivial errors, please David merge this directly into your tree.
net/ipv4/netfilter/ipt_SYNPROXY.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/netfilter/ipt_SYNPROXY.c b/net/ipv4/netfilter/ipt_SYNPROXY.c
index e9e67793055fce9b20ee836275a3eb4a9437592a..fe8cc183411e052f6e0ba4afefbeaef1e77313cd 100644
--- a/net/ipv4/netfilter/ipt_SYNPROXY.c
+++ b/net/ipv4/netfilter/ipt_SYNPROXY.c
@@ -18,7 +18,7 @@
#include <net/netfilter/nf_conntrack_synproxy.h>
static struct iphdr *
-synproxy_build_ip(struct sk_buff *skb, u32 saddr, u32 daddr)
+synproxy_build_ip(struct sk_buff *skb, __be32 saddr, __be32 daddr)
{
struct iphdr *iph;
@@ -220,7 +220,7 @@ synproxy_send_client_ack(const struct synproxy_net *snet,
nth->ack_seq = th->ack_seq;
tcp_flag_word(nth) = TCP_FLAG_ACK;
nth->doff = tcp_hdr_size / 4;
- nth->window = ntohs(htons(th->window) >> opts->wscale);
+ nth->window = htons(ntohs(th->window) >> opts->wscale);
nth->check = 0;
nth->urg_ptr = 0;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] netfilter: synproxy: fix sparse errors
2015-05-15 16:07 [PATCH net-next] netfilter: synproxy: fix sparse errors Eric Dumazet
@ 2015-05-15 18:05 ` Pablo Neira Ayuso
2015-05-17 18:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2015-05-15 18:05 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev, Patrick McHardy
On Fri, May 15, 2015 at 09:07:31AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Fix verbose sparse errors :
>
> make C=2 CF=-D__CHECK_ENDIAN__ net/ipv4/netfilter/ipt_SYNPROXY.o
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Thanks Eric.
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> Trivial errors, please David merge this directly into your tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netfilter: synproxy: fix sparse errors
2015-05-15 16:07 [PATCH net-next] netfilter: synproxy: fix sparse errors Eric Dumazet
2015-05-15 18:05 ` Pablo Neira Ayuso
@ 2015-05-17 18:11 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-05-17 18:11 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, kaber, pablo
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 15 May 2015 09:07:31 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> Fix verbose sparse errors :
>
> make C=2 CF=-D__CHECK_ENDIAN__ net/ipv4/netfilter/ipt_SYNPROXY.o
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-17 18:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-15 16:07 [PATCH net-next] netfilter: synproxy: fix sparse errors Eric Dumazet
2015-05-15 18:05 ` Pablo Neira Ayuso
2015-05-17 18:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).