From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, VenkatKumar.Duvvuru@emulex.com,
sathya.perla@avagotech.com, ajit.khaparde@avagotech.com,
padmanabh.ratnakar@avagotech.com,
sriharsha.basavapatna@avagotech.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] be2net: make hwmon interface optional
Date: Tue, 19 May 2015 16:40:22 -0400 (EDT) [thread overview]
Message-ID: <20150519.164022.444377281915355405.davem@davemloft.net> (raw)
In-Reply-To: <2638325.2pcgKkR8vC@wuerfel>
From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 18 May 2015 23:06:45 +0200
> The hwmon interface in the be2net driver causes a link error when
> be2net is built-in while the hwmon subsystem is a loadable module:
>
> drivers/built-in.o: In function `be_probe':
> drivers/net/ethernet/emulex/benet/be_main.c:5761: undefined reference to `devm_hwmon_device_register_with_groups'
>
> This adds a new Kconfig symbol, following the example of multiple
> other drivers that have the same problem. The new CONFIG_BE2NET_HWMON
> will not be available when (BE2NET=y && HWMON=m) to avoid this
> problem.
>
> We have to also mark be_hwmon_show_temp as 'static' to ensure the
> compiler can optimize out all the unused code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 29e9122b3a ("be2net: Export board temperature using hwmon-sysfs interface.")
Applied, thanks.
prev parent reply other threads:[~2015-05-19 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 21:06 [PATCH] be2net: make hwmon interface optional Arnd Bergmann
2015-05-19 20:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150519.164022.444377281915355405.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=VenkatKumar.Duvvuru@emulex.com \
--cc=ajit.khaparde@avagotech.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=padmanabh.ratnakar@avagotech.com \
--cc=sathya.perla@avagotech.com \
--cc=sriharsha.basavapatna@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).