From: David Miller <davem@davemloft.net>
To: ek@google.com
Cc: hannes@stressinduktion.org, lorenzo@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] Better handling of transition to NUD_PROBE state
Date: Thu, 21 May 2015 16:53:32 -0400 (EDT) [thread overview]
Message-ID: <20150521.165332.1552040068826483613.davem@davemloft.net> (raw)
In-Reply-To: <1431945881-14707-1-git-send-email-ek@google.com>
From: Erik Kline <ek@google.com>
Date: Mon, 18 May 2015 19:44:41 +0900
> [1] When entering NUD_PROBE state via neigh_update(), perhaps received
> from userspace, correctly (re)initialize the probes count to zero.
>
> This is useful for forcing revalidation of a neighbor (for example
> if the host is attempting to do DNA [IPv4 4436, IPv6 6059]).
>
> [2] Notify listeners when a neighbor goes into NUD_PROBE state.
>
> By sending notifications on entry to NUD_PROBE state listeners get
> more timely warnings of imminent connectivity issues.
>
> The current notifications on entry to NUD_STALE have somewhat
> limited usefulness: NUD_STALE is a perfectly normal state, as is
> NUD_DELAY, whereas notifications on entry to NUD_FAILURE come after
> a neighbor reachability problem has been confirmed (typically after
> three probes).
>
> Signed-off-by: Erik Kline <ek@google.com>
Please, in the future, put a proper subsystem prefix in the Subject
line of your patch submissions. In this particular case "neigh: "
would have been appropriate and is what I added when applying your
patch.
Applied, thanks.
next prev parent reply other threads:[~2015-05-21 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 10:44 [PATCH net-next] Better handling of transition to NUD_PROBE state Erik Kline
2015-05-20 3:42 ` Lorenzo Colitti
2015-05-20 16:10 ` Hannes Frederic Sowa
2015-05-21 20:53 ` David Miller [this message]
2015-05-22 4:32 ` Erik Kline
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521.165332.1552040068826483613.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ek@google.com \
--cc=hannes@stressinduktion.org \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).