From: Flavio Leitner <fbl@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>
Subject: Re: [PATCH net-next 1/2] inet_hashinfo: remove bsocket counter
Date: Thu, 21 May 2015 17:10:27 -0300 [thread overview]
Message-ID: <20150521201027.GH2379@x240.home> (raw)
In-Reply-To: <1432144742-17786-2-git-send-email-edumazet@google.com>
On Wed, May 20, 2015 at 10:59:01AM -0700, Eric Dumazet wrote:
> We no longer need bsocket atomic counter, as inet_csk_get_port()
> calls bind_conflict() regardless of its value, after commit
> 2b05ad33e1e624e ("tcp: bind() fix autoselection to share ports")
>
> This patch removes overhead of maintaining this counter and
> double inet_csk_get_port() calls under pressure.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Marcelo Ricardo Leitner <mleitner@redhat.com>
> Cc: Flavio Leitner <fbl@redhat.com>
> ---
The patch looks good to me.
Acked-by: Flavio Leitner <fbl@redhat.com>
next prev parent reply other threads:[~2015-05-21 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 17:59 [PATCH net-next 0/2] tcp: improve source port selection Eric Dumazet
2015-05-20 17:59 ` [PATCH net-next 1/2] inet_hashinfo: remove bsocket counter Eric Dumazet
2015-05-21 20:10 ` Flavio Leitner [this message]
2015-05-20 17:59 ` [PATCH net-next 2/2] tcp: improve REUSEADDR/NOREUSEADDR cohabitation Eric Dumazet
2015-05-21 20:37 ` Flavio Leitner
2015-05-21 22:55 ` [PATCH net-next 0/2] tcp: improve source port selection David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521201027.GH2379@x240.home \
--to=fbl@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).