Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: linus.luessing@c0d3.blue
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org,
	roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, wkok@cumulusnetworks.com,
	cwang@twopensource.com
Subject: Re: [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down
Date: Fri, 22 May 2015 14:56:36 -0400 (EDT)	[thread overview]
Message-ID: <20150522.145636.734827115116283588.davem@davemloft.net> (raw)
In-Reply-To: <1432301557-6928-1-git-send-email-linus.luessing@c0d3.blue>

From: Linus Lüssing <linus.luessing@c0d3.blue>
Date: Fri, 22 May 2015 15:32:37 +0200

> @@ -1786,14 +1784,8 @@ int br_multicast_set_router(struct net_bridge *br, unsigned long val)
>  	case 1:
>  		br->multicast_router = val;
>  		err = 0;
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}

Please don't remove the break; statement.

> @@ -1827,14 +1817,8 @@ int br_multicast_set_port_router(struct net_bridge_port *p, unsigned long val)
>  			break;
>  
>  		br_multicast_add_router(br, p);
> -		break;
> -
> -	default:
> -		err = -EINVAL;
> -		break;
>  	}
>  
> -unlock:
>  	spin_unlock(&br->multicast_lock);
>  
>  	return err;

Likewise.

Thanks.

      parent reply	other threads:[~2015-05-22 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 13:32 [PATCHv2 net-next] bridge: allow setting hash_max + multicast_router if interface is down Linus Lüssing
2015-05-22 16:26 ` Cong Wang
2015-05-22 18:56 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150522.145636.734827115116283588.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=cwang@twopensource.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linus.luessing@c0d3.blue \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    --cc=wkok@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox