From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys Date: Fri, 22 May 2015 10:14:28 +0200 Message-ID: <20150522081428.GH2138@nanopsycho.orion> References: <1432253506-3646977-1-git-send-email-tom@herbertland.com> <1432253506-3646977-10-git-send-email-tom@herbertland.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, netdev@vger.kernel.org To: Tom Herbert Return-path: Received: from mail-wi0-f172.google.com ([209.85.212.172]:34113 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754712AbbEVIOb (ORCPT ); Fri, 22 May 2015 04:14:31 -0400 Received: by wicmc15 with SMTP id mc15so33553622wic.1 for ; Fri, 22 May 2015 01:14:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1432253506-3646977-10-git-send-email-tom@herbertland.com> Sender: netdev-owner@vger.kernel.org List-ID: Fri, May 22, 2015 at 02:11:44AM CEST, tom@herbertland.com wrote: >In flow_dissector set the flow label in flow_keys for IPv6. This also >removes the shortcircuiting of flow dissection when a non-zero label >is present, the flow label can be considered to provide additional >entropy for a hash. > >Signed-off-by: Tom Herbert >--- > include/net/flow_dissector.h | 4 +++- > net/core/flow_dissector.c | 37 +++++++++++++------------------------ > 2 files changed, 16 insertions(+), 25 deletions(-) > >diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h >index 08480fb..effe607 100644 >--- a/include/net/flow_dissector.h >+++ b/include/net/flow_dissector.h >@@ -28,7 +28,8 @@ struct flow_dissector_key_basic { > }; > > struct flow_dissector_key_tags { >- u32 vlan_id:12; >+ u32 vlan_id:12, >+ flow_label:20; > }; > > /** >@@ -111,6 +112,7 @@ enum flow_dissector_key_id { > FLOW_DISSECTOR_KEY_ETH_ADDRS, /* struct flow_dissector_key_eth_addrs */ > FLOW_DISSECTOR_KEY_TIPC_ADDRS, /* struct flow_dissector_key_tipc_addrs */ > FLOW_DISSECTOR_KEY_VLANID, /* struct flow_dissector_key_flow_tags */ >+ FLOW_DISSECTOR_KEY_FLOW_LABEL, /* struct flow_dissector_key_flow_label */ I think it makes sense to pair FLOW_DISSECTOR_KEY_* with struct flow_dissector_key_* How about to have FLOW_DISSECTOR_KEY_TAGS istead of VLANID and FLOW_LABEL?