From: David Miller <davem@davemloft.net>
To: shailendra.capricorn@gmail.com
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm:he - Do not initialise statics to 0.
Date: Mon, 25 May 2015 16:36:17 -0400 (EDT) [thread overview]
Message-ID: <20150525.163617.1172231502407784808.davem@davemloft.net> (raw)
In-Reply-To: <1432583633-5129-1-git-send-email-shailendra.capricorn@gmail.com>
From: Shailendra Verma <shailendra.capricorn@gmail.com>
Date: Tue, 26 May 2015 01:23:53 +0530
> Static variables are initialised to 0 by GCC.
> Fixes the following checkpatch error:
> ERROR: do not initialise statics to 0 or NULL
> FILE: drivers/atm/he.c:120:
> static bool sdh = 0;
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
true is not necessarily '1' and false is not necessarily '0',
therefore the correct fix would be to assign 'false' to this variable.
Furthermore you've submitted this in such a way that it cannot be
applied alongside the other atm:he patch you submitted.
This is why when you submit multiple patches to the same file, you
must group them and submit them relative to eachother and in a
specific order.
next prev parent reply other threads:[~2015-05-25 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 19:53 [PATCH] atm:he - Do not initialise statics to 0 Shailendra Verma
2015-05-25 20:36 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-04 14:41 Shailendra Verma
2015-06-04 22:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525.163617.1172231502407784808.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).