From: David Miller <davem@davemloft.net>
To: hofrat@osadl.org
Cc: samuel@sortiz.org, joe@perches.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions
Date: Mon, 25 May 2015 17:39:46 -0400 (EDT) [thread overview]
Message-ID: <20150525.173946.265552397243249712.davem@davemloft.net> (raw)
In-Reply-To: <1432385190-6333-1-git-send-email-hofrat@osadl.org>
From: Nicholas Mc Guire <hofrat@osadl.org>
Date: Sat, 23 May 2015 14:46:30 +0200
> API compliance scanning with coccinelle flagged:
>
> Converting milliseconds to jiffies by "val * HZ / 1000" is technically
> is not a clean solution as it does not handle all corner cases correctly.
> By changing the conversion to use msecs_to_jiffies(val) conversion is
> correct in all cases.
>
> in the current code:
> mod_timer(&self->rx_defer_timer, jiffies + (10 * HZ / 1000));
> for HZ < 100 (e.g. CONFIG_HZ == 64|32 in alpha) this effectively results
> in no delay at all.
>
> Patch was compile tested for x86_64_defconfig (implies CONFIG_USB_IRDA=m)
>
> Patch is against 4.1-rc4 (localversion-next is -next-20150522)
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Applied to net-next, thanks.
next prev parent reply other threads:[~2015-05-25 21:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 12:46 [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions Nicholas Mc Guire
2015-05-25 21:39 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-19 10:51 Nicholas Mc Guire
2015-05-19 14:32 ` Joe Perches
2015-05-19 20:45 ` David Miller
2015-05-19 21:09 ` Joe Perches
2015-05-20 1:44 ` Guenter Roeck
2015-05-20 3:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525.173946.265552397243249712.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).