From: Nicholas Mc Guire <der.herr@hofr.at>
To: David Miller <davem@davemloft.net>
Cc: hofrat@osadl.org, samuel@sortiz.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: use msecs_to_jiffies for conversion to jiffies
Date: Mon, 25 May 2015 07:50:25 +0200 [thread overview]
Message-ID: <20150525055025.GD1397@opentech.at> (raw)
In-Reply-To: <20150524.161029.184486397241230288.davem@davemloft.net>
On Sun, 24 May 2015, David Miller wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
> Date: Sat, 23 May 2015 15:43:36 +0200
>
> > API compliance scanning with coccinelle flagged:
> > ./net/irda/timer.c:63:35-37: use of msecs_to_jiffies probably perferable
> >
> > Converting milliseconds to jiffies by "val * HZ / 1000" technically
> > is not a clean solution as it does not handle all corner cases correctly.
> > By changing the conversion to use msecs_to_jiffies(val) conversion is
> > correct in all cases. Further the () around the arithmetic expression
> > was dropped.
> >
> > Patch was compile tested for x86_64_defconfig + CONFIG_IRDA=m
> >
> > Patch is against 4.1-rc4 (localversion-next is -next-20150522)
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
>
> The appropriate subsystem prefix for this change is not "net: "
> but rather "irda: ", please update your Subject line accordingly
> and resubmit.
>
sorry - the net: cam from looking at the output of
hofrat@debian:~/git/linux-next$ git log --oneline net/irda/timer.c
d82603c treewide: Replace incomming with incoming in all comments and strings
9ffc93f Remove all #inclusions of asm/system.h
25985ed Fix common misspellings
5eaa65b net: Make static
db955170 more UTF-8 conversions
6819bc2 [NET] IRDA: Fix whitespace errors.
6ab3d56 Remove obsolete #include <linux/config.h>
where it was not really clear what prefix to use - and net: seemed the most
fitting. will fix it up and resend.
thx!
hofrat
prev parent reply other threads:[~2015-05-25 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 13:43 [PATCH] net: use msecs_to_jiffies for conversion to jiffies Nicholas Mc Guire
2015-05-24 20:10 ` David Miller
2015-05-25 5:50 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525055025.GD1397@opentech.at \
--to=der.herr@hofr.at \
--cc=davem@davemloft.net \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).