public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Sören Brinkmann" <soren.brinkmann@xilinx.com>
To: Nathan Sullivan <nathan.sullivan@ni.com>
Cc: <nicolas.ferre@atmel.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb
Date: Mon, 25 May 2015 12:14:47 -0700	[thread overview]
Message-ID: <20150525191447.GV18303@xsjsorenbubuntu> (raw)
In-Reply-To: <1432304531-23682-3-git-send-email-nathan.sullivan@ni.com>

On Fri, 2015-05-22 at 09:22AM -0500, Nathan Sullivan wrote:
> Use the new zynq binding for macb ethernet, since it will disable half
> duplex gigabit like the Zynq TRM says to do.
> 
> Signed-off-by: Nathan Sullivan <nathan.sullivan@ni.com>
> ---
>  arch/arm/boot/dts/zynq-7000.dtsi |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index a5cd2ed..9ea54b3 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -193,7 +193,7 @@
>  		};
>  
>  		gem0: ethernet@e000b000 {
> -			compatible = "cdns,gem";
> +			compatible = "cdns,zynq-gem";

Please, prepend the new string to the compatible list. Don't just
replace it like this.

>  			reg = <0xe000b000 0x1000>;
>  			status = "disabled";
>  			interrupts = <0 22 4>;
> @@ -204,7 +204,7 @@
>  		};
>  
>  		gem1: ethernet@e000c000 {
> -			compatible = "cdns,gem";
> +			compatible = "cdns,zynq-gem";

ditto

	Sören

  reply	other threads:[~2015-05-25 19:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 14:22 [PATCH v2 1/3] net: macb: Document zynq gem dt binding Nathan Sullivan
2015-05-22 14:22 ` [PATCH v2 2/3] net: macb: Disable half duplex gigabit on Zynq Nathan Sullivan
2015-05-22 14:56   ` Nicolas Ferre
2015-05-22 18:58   ` David Miller
2015-05-22 14:22 ` [PATCH v2 3/3] ARM: zynq: DT: Use the zynq binding with macb Nathan Sullivan
2015-05-25 19:14   ` Sören Brinkmann [this message]
2015-05-22 14:56 ` [PATCH v2 1/3] net: macb: Document zynq gem dt binding Nicolas Ferre
2015-05-22 18:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150525191447.GV18303@xsjsorenbubuntu \
    --to=soren.brinkmann@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan.sullivan@ni.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox