From: David Miller <davem@davemloft.net>
To: fengguang.wu@intel.com
Cc: edumazet@google.com, kbuild-all@01.org, netdev@vger.kernel.org
Subject: Re: [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree'
Date: Wed, 27 May 2015 00:19:38 -0400 (EDT) [thread overview]
Message-ID: <20150527.001938.461731083662455514.davem@davemloft.net> (raw)
In-Reply-To: <201505271204.NKEoVJFK%fengguang.wu@intel.com>
From: kbuild test robot <fengguang.wu@intel.com>
Date: Wed, 27 May 2015 12:12:08 +0800
> All error/warnings:
>
> net/ipv4/fib_trie.c: In function '__node_free_rcu':
>>> net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
> vfree(n);
> ^
> net/ipv4/fib_trie.c: In function 'tnode_alloc':
>>> net/ipv4/fib_trie.c:312:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
> return vzalloc(size);
> ^
>>> net/ipv4/fib_trie.c:312:3: warning: return makes pointer from integer without a cast
> cc1: some warnings being treated as errors
I'll take care of the fib_trie.c part:
commit ffa915d071ce4a05dcd866409df26513d25786f8
Author: David S. Miller <davem@davemloft.net>
Date: Wed May 27 00:19:03 2015 -0400
ipv4: Fix fib_trie.c build, missing linux/vmalloc.h include.
We used to get this indirectly I supposed, but no longer do.
Either way, an explicit include should have been done in the
first place.
net/ipv4/fib_trie.c: In function '__node_free_rcu':
>> net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
vfree(n);
^
net/ipv4/fib_trie.c: In function 'tnode_alloc':
>> net/ipv4/fib_trie.c:312:3: error: implicit declaration of function 'vzalloc' [-Werror=implicit-function-declaration]
return vzalloc(size);
^
>> net/ipv4/fib_trie.c:312:3: warning: return makes pointer from integer without a cast
cc1: some warnings being treated as errors
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
index 5a5d9bd..01bce15 100644
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -72,6 +72,7 @@
#include <linux/list.h>
#include <linux/slab.h>
#include <linux/export.h>
+#include <linux/vmalloc.h>
#include <net/net_namespace.h>
#include <net/ip.h>
#include <net/protocol.h>
next prev parent reply other threads:[~2015-05-27 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 4:12 [net-next:master 200/201] net/ipv4/fib_trie.c:293:3: error: implicit declaration of function 'vfree' kbuild test robot
2015-05-27 4:19 ` David Miller [this message]
2015-05-27 4:21 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527.001938.461731083662455514.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox