* [PATCH net v2] xen/netback: Properly initialize credit_bytes
@ 2015-05-27 10:44 Ross Lagerwall
2015-05-27 10:46 ` Wei Liu
2015-05-27 16:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Ross Lagerwall @ 2015-05-27 10:44 UTC (permalink / raw)
To: netdev; +Cc: xen-devel, Wei Liu, Ian Campbell, Ross Lagerwall
Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
struct") introduced a regression when moving queue-specific data into
the queue struct by failing to set the credit_bytes field. This
prevented bandwidth limiting from working. Initialize the field as it
was done before multiqueue support was added.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
Changed in v2: Fixed multiple-assignment.
drivers/net/xen-netback/xenbus.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
index 3d8dbf5..fee0241 100644
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -793,6 +793,7 @@ static void connect(struct backend_info *be)
goto err;
}
+ queue->credit_bytes = credit_bytes;
queue->remaining_credit = credit_bytes;
queue->credit_usec = credit_usec;
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] xen/netback: Properly initialize credit_bytes
2015-05-27 10:44 [PATCH net v2] xen/netback: Properly initialize credit_bytes Ross Lagerwall
@ 2015-05-27 10:46 ` Wei Liu
2015-05-27 16:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2015-05-27 10:46 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: netdev, xen-devel, Wei Liu, Ian Campbell
On Wed, May 27, 2015 at 11:44:32AM +0100, Ross Lagerwall wrote:
> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
> ---
>
> Changed in v2: Fixed multiple-assignment.
>
> drivers/net/xen-netback/xenbus.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c
> index 3d8dbf5..fee0241 100644
> --- a/drivers/net/xen-netback/xenbus.c
> +++ b/drivers/net/xen-netback/xenbus.c
> @@ -793,6 +793,7 @@ static void connect(struct backend_info *be)
> goto err;
> }
>
> + queue->credit_bytes = credit_bytes;
> queue->remaining_credit = credit_bytes;
> queue->credit_usec = credit_usec;
>
> --
> 2.1.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] xen/netback: Properly initialize credit_bytes
2015-05-27 10:44 [PATCH net v2] xen/netback: Properly initialize credit_bytes Ross Lagerwall
2015-05-27 10:46 ` Wei Liu
@ 2015-05-27 16:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-05-27 16:57 UTC (permalink / raw)
To: ross.lagerwall; +Cc: netdev, xen-devel, wei.liu2, ian.campbell
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Date: Wed, 27 May 2015 11:44:32 +0100
> Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue
> struct") introduced a regression when moving queue-specific data into
> the queue struct by failing to set the credit_bytes field. This
> prevented bandwidth limiting from working. Initialize the field as it
> was done before multiqueue support was added.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Applied, thanks Ross.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-27 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-27 10:44 [PATCH net v2] xen/netback: Properly initialize credit_bytes Ross Lagerwall
2015-05-27 10:46 ` Wei Liu
2015-05-27 16:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).