From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, hannes@stressinduktion.org
Subject: Re: [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs
Date: Wed, 27 May 2015 13:04:01 -0400 (EDT) [thread overview]
Message-ID: <20150527.130401.726728313381454100.davem@davemloft.net> (raw)
In-Reply-To: <1432305171-21932-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 22 May 2015 16:32:49 +0200
> output path tests:
>
> if (skb->len > mtu) ip_fragment()
>
> This breaks connectivity in one corner case:
> If the skb was reassembled, but has the DF bit set and ..
> .. its reassembled size is <= outdev mtu ..
> .. we will forward a DF packet larger than what the sender
> transmitted on wire.
>
> If a router later in the path can't forward this packet, it will send an
> icmp error in response to an mtu that the original sender never exceeded.
>
> This changes ipv4 defrag/output path to
>
> a) force refragmentation for DF reassembled skbs and
> b) set DF bit on all fragments when refragmenting if it was set on original
> frags.
...
Series applied, thanks Florian.
prev parent reply other threads:[~2015-05-27 17:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 14:32 [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs Florian Westphal
2015-05-22 14:32 ` [PATCH -next 1/2] net: ipv4: avoid repeated calls to ip_skb_dst_mtu helper Florian Westphal
2015-05-22 14:43 ` Hannes Frederic Sowa
2015-05-22 14:32 ` [PATCH -next 2/2] ip_fragment: don't forward defragmented DF packet Florian Westphal
2015-05-22 14:45 ` Hannes Frederic Sowa
2015-05-22 19:03 ` [PATCH -next, V3 0/2] net: force refragmentation for DF reassembed skbs David Miller
2015-05-22 19:26 ` Florian Westphal
2015-05-26 9:57 ` Maxime Bizon
2015-05-26 14:50 ` Florian Westphal
2015-05-22 22:52 ` Hannes Frederic Sowa
2015-05-27 17:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527.130401.726728313381454100.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).