From: David Miller <davem@davemloft.net>
To: david.vrabel@citrix.com
Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Subject: Re: [PATCHv1] xen-netfront: properly destroy queues when removing device
Date: Wed, 27 May 2015 14:03:37 -0400 (EDT) [thread overview]
Message-ID: <20150527.140337.2074429377294328026.davem@davemloft.net> (raw)
In-Reply-To: <1432737970-31872-1-git-send-email-david.vrabel@citrix.com>
From: David Vrabel <david.vrabel@citrix.com>
Date: Wed, 27 May 2015 15:46:10 +0100
> xennet_remove() freed the queues before freeing the netdevice which
> results in a use-after-free when free_netdev() tries to delete the
> napi instances that have already been freed.
>
> Fix this by fully destroy the queues (which includes deleting the napi
> instances) before freeing the netdevice.
>
> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Applied, thanks David.
prev parent reply other threads:[~2015-05-27 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 14:46 [PATCHv1] xen-netfront: properly destroy queues when removing device David Vrabel
2015-05-27 15:20 ` Boris Ostrovsky
2015-05-27 18:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527.140337.2074429377294328026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).