From: Steffen Klassert <steffen.klassert@secunet.com>
To: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: <davem@davemloft.net>, <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [net-next PATCH RFC 0/3] Preserve skb->mark through VTI tunnels
Date: Wed, 27 May 2015 09:48:40 +0200 [thread overview]
Message-ID: <20150527074836.GA27342@secunet.com> (raw)
In-Reply-To: <20150526223849.1328.64212.stgit@ahduyck-vm-fedora22>
On Tue, May 26, 2015 at 03:41:10PM -0700, Alexander Duyck wrote:
> These patches are meant to try and address the fact the VTI tunnels are
> currently overwriting the skb->mark value. I am generally happy with the
> first two patches, however the third patch still modifies the skb->mark,
> though it undoes after the fact.
I don't see any better solution, so I think this should be ok for now.
On the long run we need to replace this gre key/mark matching with
a separate interface.
>
> The main problem I am trying to address is the fact that currently if I use
> an v6 over v6 VTI tunnel I cannot receive any traffic on the interface as
> the skb->mark is bleeding through and causing the traffic to be dropped.
This is broken in the current mainline, so it should go into the ipsec
tree as a bugfix. I'd merge this patchset if you submit it to that tree.
Thanks!
next prev parent reply other threads:[~2015-05-27 7:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 22:41 [net-next PATCH RFC 0/3] Preserve skb->mark through VTI tunnels Alexander Duyck
2015-05-26 22:41 ` [net-next PATCH RFC 1/3] ip_vti/ip6_vti: Do not touch skb->mark on xmit Alexander Duyck
2015-05-26 22:41 ` [net-next PATCH RFC 2/3] xfrm: Override skb->mark with tunnel->parm.i_key in xfrm_input Alexander Duyck
2015-05-26 22:41 ` [net-next PATCH RFC 3/3] ip_vti/ip6_vti: Preserve skb->mark after rcv_cb call Alexander Duyck
2015-05-27 7:48 ` Steffen Klassert [this message]
2015-05-27 7:55 ` [net-next PATCH RFC 0/3] Preserve skb->mark through VTI tunnels Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527074836.GA27342@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).