From: Jiri Benc <jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Pravin Shelar <pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org>
Cc: "dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org"
<dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH net] openvswitch: disable LRO unless stated otherwise
Date: Wed, 27 May 2015 10:50:21 +0200 [thread overview]
Message-ID: <20150527105021.21879f6c@griffin> (raw)
In-Reply-To: <CALnjE+o-rHrcrmbwb4n4Py5smH3M8oOS-EBCGF2Rc0-e_Y1rmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote:
> OVS interface for generic networking device operation looks odd. have
> you considered adding new device ioctl to do this?
New ioctls for networking configuration are generally not allowed. The
preferred way to configure networking is netlink. And as this is very
much ovs specific (all other users of dev_disable_lro such as bridging
want to do this unconditionally), ovs netlink is the correct place to
put this to.
Jiri
--
Jiri Benc
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
next prev parent reply other threads:[~2015-05-27 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 17:38 [PATCH net] openvswitch: disable LRO unless stated otherwise Jiri Benc
[not found] ` <15f0c96df9cc152b05d8a5ff0c0059eb1f042cca.1432661690.git.jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-26 22:03 ` Pravin Shelar
[not found] ` <CALnjE+o-rHrcrmbwb4n4Py5smH3M8oOS-EBCGF2Rc0-e_Y1rmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-27 8:50 ` Jiri Benc [this message]
2015-05-27 13:24 ` [ovs-dev] " Flavio Leitner
2015-05-27 15:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527105021.21879f6c@griffin \
--to=jbenc-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pshelar-l0M0P4e3n4LQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox