Re: [PATCH iproute2] enable transparent LFS

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 26 May 2015 02:51:30 -0400
Mike Frysinger <vapier@gentoo.org> wrote:

> From: Mike Frysinger <vapier@chromium.org>
> 
> Make sure we use 64-bit filesystem functions everywhere.  This applies not
> only to being able to read large files (which generally doesn't apply to
> us), but also being able to simply stat them (as they might be using large
> inodes).
> 
> Signed-off-by: Mike Frysinger <vapier@chromium.org>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 35cacc4..9d35ef1 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -32,6 +32,8 @@ ADDLIB+=mpls_ntop.o mpls_pton.o
>  CC = gcc
>  HOSTCC = gcc
>  DEFINES += -D_GNU_SOURCE
> +# Turn on transparent support for LFS
> +DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>  CCOPTS = -O2
>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2

I am okay with this, is something specific it fixes or is it just
general good practice?