From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: qlcnic: clean up sysfs error codes
Date: Thu, 28 May 2015 16:28:44 -0700 (PDT)
Message-ID: <20150528.162844.418918111650211346.davem@davemloft.net>
References: <1432601385-24582-1-git-send-email-vz@mleia.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: shahed.shaikh@qlogic.com, Dept-GELinuxNICDev@qlogic.com,
	netdev@vger.kernel.org
To: vz@mleia.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([149.20.54.216]:51576 "EHLO
	shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754884AbbE1X2r (ORCPT
	<rfc822;netdev@vger.kernel.org>); Thu, 28 May 2015 19:28:47 -0400
In-Reply-To: <1432601385-24582-1-git-send-email-vz@mleia.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Vladimir Zapolskiy <vz@mleia.com>
Date: Tue, 26 May 2015 03:49:45 +0300

> Replace confusing QL_STATUS_INVALID_PARAM == -1 == -EPERM with -EINVAL
> and QLC_STATUS_UNSUPPORTED_CMD == -2 == -ENOENT with -EOPNOTSUPP, the
> latter error code is arguable, but it is already used in the driver,
> so let it be here as well.
> 
> Also remove always false (!buf) check on read(), the driver should
> not care if userspace gets its EFAULT or not.
> 
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>

Qlogic folks, I'm waiting for your promised feedback.