From: Steffen Klassert <steffen.klassert@secunet.com>
To: Alexander Duyck <alexander.h.duyck@redhat.com>
Cc: <davem@davemloft.net>, <herbert@gondor.apana.org.au>,
<netdev@vger.kernel.org>, <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels
Date: Thu, 28 May 2015 07:36:08 +0200 [thread overview]
Message-ID: <20150528053607.GF27342@secunet.com> (raw)
In-Reply-To: <20150527173823.1415.96248.stgit@ahduyck-vm-fedora22>
On Wed, May 27, 2015 at 10:40:32AM -0700, Alexander Duyck wrote:
> This change makes it so that we use icmpv6_send to report PMTU issues back
> into tunnels in the case that the resulting packet is larger than the MTU
> of the outgoing interface. Previously xfrm_local_error was being used in
> this case, however this was resulting in no changes, I suspect due to the
> fact that the tunnel itself was being kept out of the loop.
>
> This patch fixes PMTU problems seen on ip6_vti tunnels and is based on the
> behavior seen if the socket was orphaned. Instead of requiring the socket
> to be orphaned this patch simply defaults to using icmpv6_send in the case
> that the frame came though a tunnel.
We can use icmpv6_send() just in the case that the packet
was already transmitted by a tunnel device, otherwise we
get the bug back that I mentioned in my other mail.
Not sure if we have something to know that the packet
traversed a tunnel device. That's what I asked in the
thread 'Looking for a lost patch'.
next prev parent reply other threads:[~2015-05-28 5:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 17:40 [PATCH] xfrm6: Do not use xfrm_local_error for path MTU issues in tunnels Alexander Duyck
2015-05-28 4:49 ` Herbert Xu
2015-05-28 4:56 ` Steffen Klassert
2015-05-28 5:36 ` Steffen Klassert [this message]
2015-05-28 7:18 ` Alexander Duyck
2015-05-28 8:40 ` Steffen Klassert
2015-05-28 19:15 ` Alexander Duyck
2015-05-29 16:53 ` Alexander Duyck
2015-05-29 18:28 ` [PATCH] vti6: Add pmtu handling to vti6_xmit Alexander Duyck
2015-06-01 23:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528053607.GF27342@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=alexander.h.duyck@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).