From: Dan Carpenter <dan.carpenter@oracle.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: olaf@aepfle.de, netdev@vger.kernel.org, jasowang@redhat.com,
linux-kernel@vger.kernel.org, apw@canonical.com,
devel@linuxdriverproject.org, davem@davemloft.net
Subject: Re: [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues
Date: Thu, 28 May 2015 10:06:13 +0300 [thread overview]
Message-ID: <20150528070613.GV11588@mwanda> (raw)
In-Reply-To: <1432682469-15033-1-git-send-email-kys@microsoft.com>
Since you're redoing this anyway.
On Tue, May 26, 2015 at 04:21:09PM -0700, K. Y. Srinivasan wrote:
> diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
> index ddcc7f8..dd45440 100644
> --- a/drivers/net/hyperv/hyperv_net.h
> +++ b/drivers/net/hyperv/hyperv_net.h
> @@ -161,6 +161,7 @@ struct netvsc_device_info {
> unsigned char mac_adr[ETH_ALEN];
> bool link_state; /* 0 - link up, 1 - link down */
> int ring_size;
> + u32 max_num_vrss_chns;
We (Joe and I) have commented before that long names don't mix well with
the 80 character limit. You could just leave the "num_" out. Almost
all variables are numbers in C so it doesn't add anything.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-28 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:21 [PATCH net-next 1/1] hv_netvsc: Properly size the vrss queues K. Y. Srinivasan
2015-05-27 18:12 ` David Miller
2015-05-27 18:20 ` KY Srinivasan
2015-05-28 7:06 ` Dan Carpenter [this message]
2015-05-28 13:52 ` KY Srinivasan
2015-05-28 13:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150528070613.GV11588@mwanda \
--to=dan.carpenter@oracle.com \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).