From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, varenet@parisc-linux.org
Subject: Re: Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin
Date: Fri, 29 May 2015 17:59:13 +0200 [thread overview]
Message-ID: <20150529155912.GA2669@1wt.eu> (raw)
In-Reply-To: <1432914731.7456.91.camel@edumazet-glaptop2.roam.corp.google.com>
Hi Eric,
On Fri, May 29, 2015 at 08:52:11AM -0700, Eric Dumazet wrote:
> On Fri, 2015-05-29 at 08:12 -0700, Stephen Hemminger wrote:
> > I think 2.6.32 is so old no one will care.
A few will still, but at least we must ensure the old guy finishes
his days nicely :-)
(...)
> I guess a backport went wrong.
Ah crap, sorry about that :-(
> Willy, please add following to your tree :
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index 5339f066234b..d1e2895bb63c 100644
> --- a/net/ipv4/tcp_output.c
> +++ b/net/ipv4/tcp_output.c
> @@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk)
> */
> if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) {
> coalesce:
> - TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN;
> + TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN;
> TCP_SKB_CB(tskb)->end_seq++;
> tp->write_seq++;
> if (!tcp_send_head(sk)) {
Thanks Eric, I'm queuing this now.
Best regards,
Willy
prev parent reply other threads:[~2015-05-29 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 15:12 Fw: [Bug 99161] New: 2.6.32.66 PPC Oops in tcp_send_fin Stephen Hemminger
2015-05-29 15:52 ` Eric Dumazet
2015-05-29 15:59 ` Willy Tarreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150529155912.GA2669@1wt.eu \
--to=w@1wt.eu \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=varenet@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).