From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: netdev@vger.kernel.org, sgoutham@cavium.com, mjc@semihalf.com,
david.daney@cavium.com, ganapatrao.kulkarni@caviumnetworks.com,
aleksey.makarov@caviumnetworks.com, tomasz.nowicki@linaro.org,
rrichter@cavium.com, kamil@semihalf.com,
tsrinivasulu@caviumnetworks.com, svangala@cavium.com
Subject: Re: [PATCH] net: thunderx: add 64-bit dependency
Date: Sat, 30 May 2015 23:39:06 -0700 (PDT) [thread overview]
Message-ID: <20150530.233906.1834698625091975461.davem@davemloft.net> (raw)
In-Reply-To: <5799754.oCDa9qX0W8@wuerfel>
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 28 May 2015 16:00:46 +0200
> The thunderx ethernet driver fails to build on architectures
> that do not have an atomic readq() and writeq() function for
> 64-bit PCI bus access:
>
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_reg_read':
> include/asm-generic/io.h:195:23: error: implicit declaration of function 'readq' [-Werror=implicit-function-declaration]
>
> It seems impossible to get this driver to work on most 32-bit
> hardware, so it's better to add an explicit dependency, in
> order to let us keep building 'allmodconfig' kernels on
> all architectures.
>
> As the driver is meant for the internal hardware on an arm64 SoC, this
> is not a problem for usability. Allowing the build on all 64-bit
> architectures rather than just CONFIG_ARM64 on the other hand means that
> we get the benefit of build testing on x86.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
prev parent reply other threads:[~2015-05-31 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 14:00 [PATCH] net: thunderx: add 64-bit dependency Arnd Bergmann
2015-05-28 15:49 ` David Daney
2015-05-31 6:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150530.233906.1834698625091975461.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aleksey.makarov@caviumnetworks.com \
--cc=arnd@arndb.de \
--cc=david.daney@cavium.com \
--cc=ganapatrao.kulkarni@caviumnetworks.com \
--cc=kamil@semihalf.com \
--cc=mjc@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rrichter@cavium.com \
--cc=sgoutham@cavium.com \
--cc=svangala@cavium.com \
--cc=tomasz.nowicki@linaro.org \
--cc=tsrinivasulu@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).