From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH] can: mcp251x: not correct register address Date: Sat, 30 May 2015 09:41:06 +0200 Message-ID: <20150530094106.72862564@north> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-can@vger.kernel.org, andri.yngvason@marel.com, mkl@pengutronix.de, himangi774@gmail.com, netdev@vger.kernel.org To: Tomas Krcka Return-path: Received: from mx3.wp.pl ([212.77.101.9]:30662 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752574AbbE3HlP (ORCPT ); Sat, 30 May 2015 03:41:15 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 25 May 2015 08:57:48 +0200, Tomas Krcka wrote: > This patch corrects addresses of acceptance filters. > These registers are not in use, but values should be correct. > Tested with MCP2515 and am3352 and also checked datasheets for MCP2515 > and MCP2510. > > Signed-off-by: Tomas Krcka > > --- > drivers/net/can/spi/mcp251x.c | 9 +++++---- > 1 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c > index bf63fee..c1a95a3 100644 > --- a/drivers/net/can/spi/mcp251x.c > +++ b/drivers/net/can/spi/mcp251x.c > @@ -190,10 +190,11 @@ > #define RXBEID0_OFF 4 > #define RXBDLC_OFF 5 > #define RXBDAT_OFF 6 > -#define RXFSIDH(n) ((n) * 4) > -#define RXFSIDL(n) ((n) * 4 + 1) > -#define RXFEID8(n) ((n) * 4 + 2) > -#define RXFEID0(n) ((n) * 4 + 3) > +#define RXFSID(n) ((n < 3) ? 0 : 4) > +#define RXFSIDH(n) ((n) * 4 + RXFSID(n)) > +#define RXFSIDL(n) ((n) * 4 + 1 + RXFSID(n)) > +#define RXFEID8(n) ((n) * 4 + 2 + RXFSID(n)) > +#define RXFEID0(n) ((n) * 4 + 3 + RXFSID(n)) > #define RXMSIDH(n) ((n) * 4 + 0x20) > #define RXMSIDL(n) ((n) * 4 + 0x21) > #define RXMEID8(n) ((n) * 4 + 0x22) I think your patch was corrupted. It doesn't apply because you have extra space before each surviving #define.