* [PATCH] ethernet/intel: Use setup_timer
@ 2015-06-01 4:43 Vaishali Thakkar
2015-06-01 4:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-06-01 4:43 UTC (permalink / raw)
To: Jeff Kirsher
Cc: Jesse Brandeburg, Shannon Nelson, Carolyn Wyborny, Don Skidmore,
Matthew Vick, John Ronciak, Mitch Williams, intel-wired-lan,
netdev, linux-kernel, Julia Lawall
Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.
A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:
@change@
expression e1, e2, e3, e4, a, b;
@@
-init_timer(&e1);
+setup_timer(&e1, a, b);
... when != a = e2
when != b = e3
-e1.function = a;
... when != b = e4
-e1.data = b;
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/net/ethernet/intel/e100.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/e100.c b/drivers/net/ethernet/intel/e100.c
index 1a450f4..8ae9c0d 100644
--- a/drivers/net/ethernet/intel/e100.c
+++ b/drivers/net/ethernet/intel/e100.c
@@ -2922,9 +2922,7 @@ static int e100_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
pci_set_master(pdev);
- init_timer(&nic->watchdog);
- nic->watchdog.function = e100_watchdog;
- nic->watchdog.data = (unsigned long)nic;
+ setup_timer(&nic->watchdog, e100_watchdog, (unsigned long)nic);
INIT_WORK(&nic->tx_timeout_task, e100_tx_timeout_task);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ethernet/intel: Use setup_timer
2015-06-01 4:43 [PATCH] ethernet/intel: Use setup_timer Vaishali Thakkar
@ 2015-06-01 4:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-01 4:46 UTC (permalink / raw)
Cc: jeffrey.t.kirsher, jesse.brandeburg, shannon.nelson,
carolyn.wyborny, donald.c.skidmore, matthew.vick, john.ronciak,
mitch.a.williams, intel-wired-lan, netdev, linux-kernel,
julia.lawall
From: Vaishali Thakkar <vthakkar1994@gmail.com>
Date: Mon, 1 Jun 2015 10:13:49 +0530
> Use the timer API function setup_timer instead of structure field
> assignments to initialize a timer.
>
> A simplified version of the Coccinelle semantic patch that performs
> this transformation is as follows:
>
> @change@
> expression e1, e2, e3, e4, a, b;
> @@
>
> -init_timer(&e1);
> +setup_timer(&e1, a, b);
>
> ... when != a = e2
> when != b = e3
>
> -e1.function = a;
> ... when != b = e4
> -e1.data = b;
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-01 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-01 4:43 [PATCH] ethernet/intel: Use setup_timer Vaishali Thakkar
2015-06-01 4:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).