* [PATCH] xen-netfront: Use setup_timer
@ 2015-06-01 4:58 Vaishali Thakkar
2015-06-01 5:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-06-01 4:58 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky, David Vrabel, xen-devel, netdev, linux-kernel,
Julia Lawall
Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.
A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:
@change@
expression e, func, da;
@@
-init_timer (&e);
+setup_timer (&e, func, da);
-e.data = da;
-e.function = func;
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/net/xen-netfront.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 3f45afd..10a087a 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -1560,9 +1560,8 @@ static int xennet_init_queue(struct netfront_queue *queue)
spin_lock_init(&queue->tx_lock);
spin_lock_init(&queue->rx_lock);
- init_timer(&queue->rx_refill_timer);
- queue->rx_refill_timer.data = (unsigned long)queue;
- queue->rx_refill_timer.function = rx_refill_timeout;
+ setup_timer(&queue->rx_refill_timer, rx_refill_timeout,
+ (unsigned long)queue);
snprintf(queue->name, sizeof(queue->name), "%s-q%u",
queue->info->netdev->name, queue->id);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen-netfront: Use setup_timer
2015-06-01 4:58 [PATCH] xen-netfront: Use setup_timer Vaishali Thakkar
@ 2015-06-01 5:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-06-01 5:26 UTC (permalink / raw)
To: vthakkar1994
Cc: konrad.wilk, boris.ostrovsky, david.vrabel, xen-devel, netdev,
linux-kernel, julia.lawall
From: Vaishali Thakkar <vthakkar1994@gmail.com>
Date: Mon, 1 Jun 2015 10:28:37 +0530
> Use the timer API function setup_timer instead of structure field
> assignments to initialize a timer.
>
> A simplified version of the Coccinelle semantic patch that performs
> this transformation is as follows:
>
> @change@
> expression e, func, da;
> @@
>
> -init_timer (&e);
> +setup_timer (&e, func, da);
> -e.data = da;
> -e.function = func;
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-01 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-01 4:58 [PATCH] xen-netfront: Use setup_timer Vaishali Thakkar
2015-06-01 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).