From: David Miller <davem@davemloft.net>
To: ian.campbell@citrix.com
Cc: xen-devel@lists.xen.org, netdev@vger.kernel.org, wei.liu2@citrix.com
Subject: Re: [PATCH v2] xen: netback: fix printf format string warning
Date: Mon, 01 Jun 2015 12:03:43 -0700 (PDT) [thread overview]
Message-ID: <20150601.120343.1122621914202084967.davem@davemloft.net> (raw)
In-Reply-To: <1433154604-27997-1-git-send-email-ian.campbell@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Mon, 1 Jun 2015 11:30:04 +0100
> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
> drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]
> (txreq.offset&~PAGE_MASK) + txreq.size);
> ^
>
> PAGE_MASK's type can vary by arch, so a cast is needed.
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ----
> v2: Cast to unsigned long, since PAGE_MASK can vary by arch.
Applied.
prev parent reply other threads:[~2015-06-01 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 10:30 [PATCH v2] xen: netback: fix printf format string warning Ian Campbell
2015-06-01 11:23 ` Wei Liu
2015-06-01 19:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601.120343.1122621914202084967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).