From: David Miller <davem@davemloft.net>
To: aparames@broadcom.com
Cc: ben@decadent.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, rjui@broadcom.com,
sbranden@broadcom.com, jdzheng@broadcom.com
Subject: Re: [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings
Date: Mon, 01 Jun 2015 14:46:35 -0700 (PDT) [thread overview]
Message-ID: <20150601.144635.1116373189875340733.davem@davemloft.net> (raw)
In-Reply-To: <556CD197.8070401@broadcom.com>
From: Arun Parameswaran <aparames@broadcom.com>
Date: Mon, 1 Jun 2015 14:41:43 -0700
> It would be nice for the 'ethtool' to be flexible to support querying
> specific PHY irrespective of the net implementation, but that is being
> discussed in the other thread.
Please stop arguing about this, it isn't valid.
Your device is a switch, and therefore needs to be represented properly
with the proper number of net_device objects.
Even more importantly, the ethtool API is established and you cannot
change these semantics without potentially breaking lots of applications
and libraries out there.
Your change is reverted, and I will absolutely not entertain any
attempt to again change the semantics of this ethtool operation.
Thanks.
next prev parent reply other threads:[~2015-06-01 21:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 21:35 [PATCH 0/1] Fix an issue with 'ethtool' configuring PHYs Arun Parameswaran
2015-05-20 21:35 ` [PATCH 1/1] net: core: 'ethtool' issue with querying phy settings Arun Parameswaran
2015-05-22 20:15 ` David Miller
2015-05-31 19:54 ` Ben Hutchings
2015-06-01 0:19 ` David Miller
2015-06-01 18:05 ` Ben Hutchings
2015-06-01 21:41 ` Arun Parameswaran
2015-06-01 21:46 ` David Miller [this message]
2015-06-01 23:53 ` Arun Parameswaran
2015-06-01 23:55 ` David Miller
2015-06-02 0:57 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601.144635.1116373189875340733.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aparames@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ben@decadent.org.uk \
--cc=jdzheng@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).