From: David Miller <davem@davemloft.net>
To: simon.horman@netronome.com
Cc: sfeldma@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker_port parameter
Date: Mon, 01 Jun 2015 16:05:56 -0700 (PDT) [thread overview]
Message-ID: <20150601.160556.2300618386117820098.davem@davemloft.net> (raw)
In-Reply-To: <1433132704-21927-1-git-send-email-simon.horman@netronome.com>
From: Simon Horman <simon.horman@netronome.com>
Date: Mon, 1 Jun 2015 13:25:04 +0900
> The rocker (switch) of a rocker_port may be trivially obtained from
> the latter it seems cleaner not to pass the former to a function when
> the latter is being passed anyway.
>
> rocker_port_rx_proc() is omitted from this change as it is a hot path case.
>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
> Acked-by: Scott Feldman <sfeldma@gmail.com>
Applied, thanks Simon.
Andy, DO NOT quote an entire patch just to ACK it.
That is, unless you think my time is better spend scrolling over and
over across multiple copies of the same patch in the patchwork page
while I review a change than it is spent actually reviewing people's
work.
next prev parent reply other threads:[~2015-06-01 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 4:25 [PATCH net-next v2] rocker: remove rocker parameter from functions that have rocker_port parameter Simon Horman
2015-06-01 20:09 ` Andy Gospodarek
2015-06-01 23:05 ` David Miller [this message]
2015-06-02 13:13 ` Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601.160556.2300618386117820098.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).