netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zhengjunling@huawei.com
Cc: gregkh@linuxfoundation.org, lizefan@huawei.com,
	viro@zeniv.linux.org.uk, xuhanbing@huawei.com,
	stable@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg
Date: Mon, 01 Jun 2015 16:54:07 -0700 (PDT)	[thread overview]
Message-ID: <20150601.165407.734100251470140931.davem@davemloft.net> (raw)
In-Reply-To: <1433150880-9976-1-git-send-email-zhengjunling@huawei.com>

From: Junling Zheng <zhengjunling@huawei.com>
Date: Mon, 1 Jun 2015 09:28:00 +0000

> We found that after v3.10.73, recvmsg might return -EFAULT while -EINVAL
> was expected.
> 
> We tested it through the recvmsg01 testcase come from LTP testsuit. It set
> msg->msg_namelen to -1 and the recvmsg syscall returned errno 14, which is
> unexpected (errno 22 is expected):
> 
> recvmsg01    4  TFAIL  :  invalid socket length ; returned -1 (expected -1),
> errno 14 (expected 22)
> 
> Linux mainline has no this bug for commit 08adb7dab fixes it accidentally.
> However, it is too large and complex to be backported to LTS 3.10.
> 
> So, I made the following patch to fix the above problem for LTS 3.10.

Upstream the code doesn't look anything like this, so it's probably
just a missing bug fix for -stable.

  reply	other threads:[~2015-06-01 23:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  9:28 [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Junling Zheng
2015-06-01 23:54 ` David Miller [this message]
2015-06-02  1:21 ` Greg KH
2015-06-02  4:05   ` Junling Zheng
2015-06-02  4:44     ` Greg KH
2015-06-02  6:19       ` Junling Zheng
2015-06-02  5:23     ` David Miller
2015-06-02  6:27       ` Greg KH
2015-06-02  6:43         ` Junling Zheng
2015-06-02  6:52           ` Willy Tarreau
2015-06-02  7:05             ` Junling Zheng
2015-06-02 10:15               ` Luis Henriques
2015-06-02  6:33       ` Junling Zheng
2015-06-02  6:27 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.10-stable tree gregkh
2015-06-02 13:00 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.14-stable tree gregkh
2015-08-01 19:36 ` [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150601.165407.734100251470140931.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=lizefan@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xuhanbing@huawei.com \
    --cc=zhengjunling@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).