From: Willy Tarreau <w@1wt.eu>
To: Junling Zheng <zhengjunling@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
lizefan@huawei.com, viro@zeniv.linux.org.uk,
xuhanbing@huawei.com, stable@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg
Date: Tue, 2 Jun 2015 08:52:57 +0200 [thread overview]
Message-ID: <20150602065257.GA29335@1wt.eu> (raw)
In-Reply-To: <556D50AA.4000005@huawei.com>
On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote:
> On 2015/6/2 14:27, Greg KH wrote:
> > On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote:
> >> From: Junling Zheng <zhengjunling@huawei.com>
> >> Date: Tue, 2 Jun 2015 12:05:32 +0800
> >>
> >>> So, the problem commit is 281c9c36 (net: compat: Update
> >>> get_compat_msghdr() to match copy_msghdr_from_user() behaviour),
> >>> which fixes db31c55a6fb2 and brings the get_compat_msghdr() in line
> >>> with copy_msghdr_from_user().
> >>
> >> Upstream this got fixed by:
> >>
> >> 08adb7dabd4874cc5666b4490653b26534702ce0
> >>
> >> So the part that makes us not unconditionally return -EFAULT needs
> >> to be backported, and that's probably equivalent to the patch
> >> your proposed which therefore should be applied.
> >
> > Ok, thanks, now applied.
> >
>
> Maybe other stable version also needs this fix:)
Yes, from what I'm seeing, at least 3.2 and 2.6.32 need it as well.
Thanks,
Willy
next prev parent reply other threads:[~2015-06-02 6:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 9:28 [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Junling Zheng
2015-06-01 23:54 ` David Miller
2015-06-02 1:21 ` Greg KH
2015-06-02 4:05 ` Junling Zheng
2015-06-02 4:44 ` Greg KH
2015-06-02 6:19 ` Junling Zheng
2015-06-02 5:23 ` David Miller
2015-06-02 6:27 ` Greg KH
2015-06-02 6:43 ` Junling Zheng
2015-06-02 6:52 ` Willy Tarreau [this message]
2015-06-02 7:05 ` Junling Zheng
2015-06-02 10:15 ` Luis Henriques
2015-06-02 6:33 ` Junling Zheng
2015-06-02 6:27 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.10-stable tree gregkh
2015-06-02 13:00 ` Patch "net: socket: Fix the wrong returns for recvmsg and sendmsg" has been added to the 3.14-stable tree gregkh
2015-08-01 19:36 ` [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602065257.GA29335@1wt.eu \
--to=w@1wt.eu \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xuhanbing@huawei.com \
--cc=zhengjunling@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).