From: David Miller <davem@davemloft.net>
To: ast@plumgrid.com
Cc: holzheu@linux.vnet.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, daniel@iogearbox.net,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] s390/bpf: fix stack allocation
Date: Wed, 03 Jun 2015 19:32:04 -0700 (PDT) [thread overview]
Message-ID: <20150603.193204.215182154047808316.davem@davemloft.net> (raw)
In-Reply-To: <1433224115-28411-1-git-send-email-ast@plumgrid.com>
From: Alexei Starovoitov <ast@plumgrid.com>
Date: Mon, 1 Jun 2015 22:48:34 -0700
> From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
>
> On s390x we have to provide 160 bytes stack space before we can call
> the next function. From the 160 bytes that we got from the previous
> function we only use 11 * 8 bytes and have 160 - 11 * 8 bytes left.
> Currently for BPF we allocate additional 160 - 11 * 8 bytes for the
> next function. This is wrong because then the next function only gets:
>
> (160 - 11 * 8) + (160 - 11 * 8) = 2 * 72 = 144 bytes
>
> Fix this and allocate enough memory for the next function.
>
> Fixes: 054623105728 ("s390/bpf: Add s390x eBPF JIT compiler backend")
> Signed-off-by: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com>
Applied.
prev parent reply other threads:[~2015-06-04 2:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 5:48 [PATCH net 1/2] s390/bpf: fix stack allocation Alexei Starovoitov
2015-06-02 5:48 ` [PATCH net 2/2] s390/bpf: fix bpf frame pointer setup Alexei Starovoitov
2015-06-04 2:32 ` David Miller
2015-06-04 2:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603.193204.215182154047808316.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@plumgrid.com \
--cc=daniel@iogearbox.net \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).