From: David Miller <davem@davemloft.net>
To: ogerlitz@mellanox.com
Cc: netdev@vger.kernel.org, mpe@ellerman.id.au, amirv@mellanox.com,
matanb@mellanox.com
Subject: Re: [PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes
Date: Wed, 03 Jun 2015 19:36:15 -0700 (PDT) [thread overview]
Message-ID: <20150603.193615.834853895798751401.davem@davemloft.net> (raw)
In-Reply-To: <1433230188-29726-1-git-send-email-ogerlitz@mellanox.com>
From: Or Gerlitz <ogerlitz@mellanox.com>
Date: Tue, 2 Jun 2015 10:29:48 +0300
> When CONFIG_RFS_ACCEL or SMP aren't set, we fail to build, fix it.
>
> Also, avoid build warning as of unused function on that setup.
>
> Fixes: c66fa19c405a ('net/mlx4: Add EQ pool')
> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Matan Barak <matanb@mellanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Applied, but this is really silly.
The whole reason there are backup non-SMP inline versions of
irq_set_affinity_hint() is so that drivers don't have to crap
up their drivers with ifdef'ery like this.
Just make all of this code unconditional and ignore the error,
there isn't anything you can really do if the error happens
anyways and this allows you to just silently use the non-SMP
variant which unconditionally returns -EINVAL.
prev parent reply other threads:[~2015-06-04 2:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 7:29 [PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes Or Gerlitz
2015-06-04 2:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150603.193615.834853895798751401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=matanb@mellanox.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).