netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ethernet: micrel: use time_after_eq
@ 2015-06-02 12:35 Antonio Murdaca
       [not found] ` <CAA7r0fox5CR8u=uQgUD0EojodksrjFRvOsvsJXtQKJZfd3V8dg@mail.gmail.com>
  2015-06-04  2:39 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Antonio Murdaca @ 2015-06-02 12:35 UTC (permalink / raw)
  To: davem; +Cc: netdev, linux-kernel, joe, julia.lawall, akpm, Antonio Murdaca

use the time_after_eq macro for jiffies comparison operation

Signed-off-by: Antonio Murdaca <antonio.murdaca@gmail.com>
---
 drivers/net/ethernet/micrel/ksz884x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c
index 6f332eb..48d2aec 100644
--- a/drivers/net/ethernet/micrel/ksz884x.c
+++ b/drivers/net/ethernet/micrel/ksz884x.c
@@ -6664,7 +6664,7 @@ static void mib_read_work(struct work_struct *work)
 				wake_up_interruptible(
 					&hw_priv->counter[i].counter);
 			}
-		} else if (jiffies >= hw_priv->counter[i].time) {
+		} else if (time_after_eq(jiffies, hw_priv->counter[i].time)) {
 			/* Only read MIB counters when the port is connected. */
 			if (media_connected == mib->state)
 				hw_priv->counter[i].read = 1;
-- 
2.4.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethernet: micrel: use time_after_eq
       [not found] ` <CAA7r0fox5CR8u=uQgUD0EojodksrjFRvOsvsJXtQKJZfd3V8dg@mail.gmail.com>
@ 2015-06-03 16:40   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2015-06-03 16:40 UTC (permalink / raw)
  To: Antonio Murdaca
  Cc: davem, netdev, linux-kernel, julia.lawall, akpm, Antonio Murdaca

On Wed, 2015-06-03 at 15:40 +0200, Antonio Murdaca wrote:
> Did I make some mistakes with this patch? Seeking help|info since this is
> one my very first contribution to the kernel..

Please be patient and wait for the review process
to take place.

It can take weeks before you get a reply.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ethernet: micrel: use time_after_eq
  2015-06-02 12:35 [PATCH] ethernet: micrel: use time_after_eq Antonio Murdaca
       [not found] ` <CAA7r0fox5CR8u=uQgUD0EojodksrjFRvOsvsJXtQKJZfd3V8dg@mail.gmail.com>
@ 2015-06-04  2:39 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-06-04  2:39 UTC (permalink / raw)
  To: antoniomurdaca
  Cc: netdev, linux-kernel, joe, julia.lawall, akpm, antonio.murdaca

From: Antonio Murdaca <antoniomurdaca@gmail.com>
Date: Tue,  2 Jun 2015 14:35:52 +0200

> use the time_after_eq macro for jiffies comparison operation
> 
> Signed-off-by: Antonio Murdaca <antonio.murdaca@gmail.com>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-04  2:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-02 12:35 [PATCH] ethernet: micrel: use time_after_eq Antonio Murdaca
     [not found] ` <CAA7r0fox5CR8u=uQgUD0EojodksrjFRvOsvsJXtQKJZfd3V8dg@mail.gmail.com>
2015-06-03 16:40   ` Joe Perches
2015-06-04  2:39 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).